From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH] Volume control quirk for QuickCam E 3500
Date: Wed, 22 Jul 2009 13:40:58 +0200
Message-ID: <s5hfxcp0wtx.wl%tiwai@suse.de>
References: <s5hy6qh12rs.wl%tiwai@suse.de>
	<1248259376-5204-1-git-send-email-bug-track@fisher-privat.net>
	<s5hocrd0zfp.wl%tiwai@suse.de> <4A66F857.9090309@fisher-privat.net>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from mx1.suse.de (cantor.suse.de [195.135.220.2])
	by alsa0.perex.cz (Postfix) with ESMTP id 89E0F1038CB
	for <alsa-devel@alsa-project.org>;
	Wed, 22 Jul 2009 13:40:58 +0200 (CEST)
In-Reply-To: <4A66F857.9090309@fisher-privat.net>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Sender: alsa-devel-bounces@alsa-project.org
Errors-To: alsa-devel-bounces@alsa-project.org
To: Alexey Fisher <bug-track@fisher-privat.net>
Cc: alsa-devel@alsa-project.org, clemens@ladisch.de
List-Id: alsa-devel@alsa-project.org

At Wed, 22 Jul 2009 13:30:31 +0200,
Alexey Fisher wrote:
> 
> Takashi Iwai schrieb:
> > At Wed, 22 Jul 2009 12:42:56 +0200,
> > Alexey Fisher wrote:
> >> - E3500 report cval->max more than it actually can handel, so if you
> >> set 95% capture level it will be silently muted.
> >> - Betwen cval->min and cval-max(real) is 2940 control units,
> >> but real are only 7 with cval->res = 384.
> >> - Alsa can't handel less than 10 controls, so make it more
> >> and set cval->res = 192.
> >>
> >> Signed-off-by: Alexey Fisher <bug-track@fisher-privat.net>
> > 
> > They miss still break lines...
> > Could you fix it?
> 
> Ok, i'll do every time checkpatch.pl. I promise :)

Ah, no, what I meant is to add "break;" line after each case in the
switch block...


Takashi