From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH] hda empty modelname comparison
Date: Thu, 08 Mar 2007 15:32:45 +0100
Message-ID: <s5hfy8fkdpu.wl%tiwai@suse.de>
References: <45ED81BE.4080606@amd.com>
	<1173297870.4531.4.camel@razman.gruemaster.com>
	<s5hodn4agyz.wl%tiwai@suse.de>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@lists.sourceforge.net>
In-Reply-To: <s5hodn4agyz.wl%tiwai@suse.de>
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum=alsa-devel>
List-Post: <mailto:alsa-devel@lists.sourceforge.net>
List-Help: <mailto:alsa-devel-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@lists.sourceforge.net?subject=subscribe>
Sender: alsa-devel-bounces@lists.sourceforge.net
Errors-To: alsa-devel-bounces@lists.sourceforge.net
To: Tobin Davis <tdavis@dsl-only.net>
Cc: Joachim Deguara <joachim.deguara@amd.com>, alsa-devel@lists.sourceforge.net
List-Id: alsa-devel@alsa-project.org

At Wed, 07 Mar 2007 22:20:20 +0100,
I wrote:
> 
> At Wed, 07 Mar 2007 12:04:30 -0800,
> Tobin Davis wrote:
> > 
> > On Tue, 2007-03-06 at 15:59 +0100, Joachim Deguara wrote:
> > 
> >     This patch prevents a comparison between a possibly empty modelname
> >     string in the hda code.
> >     
> >     -Joachim
> > 
> > Unfortunately, the way the original patch was written, the only options are
> > generic or segfault.  Your patch just removes the segfault, sending all cards
> > to the generic parser.
> > 
> > I've tested a slightly different approach, based on your empty test, just
> > reverse logic.  Test it to confirm that it works.  It works on my system with
> > a Conexant reference board and a Sigmatel STAC9227 (both on the same system).
> > 
> > Signed off by Tobin Davis <tdavis@dsl-only.net>                               
> That's my bad.  I haven't tested much, and unfortunately, 1.0.14rc3
> was released while I've been in vacation soon after the wrong patch.
> 
> The fix patch below is already on my local tree, but it couldn't be
> pushed because the ALSA HG tree is currently down (I guess Jaroslav is
> working on his server).  If needed, we'll release the fixed version.
> So stay tuned.

Now fixed on HG tree.


Takashi

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV