From: Takashi Iwai <tiwai@suse.de>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc: "moderated list:SOUND" <alsa-devel@alsa-project.org>,
Dmitry Panchenko <dmitry@d-systems.ee>,
Dylan Robinson <dylan_robinson@motu.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Chris Wulff <crwulff@gmail.com>,
tiwai@suse.com, "Gustavo A. R. Silva" <gustavoars@kernel.org>,
Joakim Tjernlund <joakim.tjernlund@infinera.com>,
Alexander Tsoy <alexander@tsoy.me>,
Mark Brown <broonie@kernel.org>, Joe Perches <joe@perches.com>,
Olivia Mackintosh <livvy@base.nu>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ALSA: usb-audio: Disable USB autosuspend properly in setup_disable_autosuspend()
Date: Thu, 04 Mar 2021 09:10:22 +0100 [thread overview]
Message-ID: <s5hh7lrbaq9.wl-tiwai@suse.de> (raw)
In-Reply-To: <20210304043419.287191-1-kai.heng.feng@canonical.com>
On Thu, 04 Mar 2021 05:34:16 +0100,
Kai-Heng Feng wrote:
>
> Rear audio on Lenovo ThinkStation P620 stops working after commit
> 1965c4364bdd ("ALSA: usb-audio: Disable autosuspend for Lenovo
> ThinkStation P620"):
> [ 6.013526] usbcore: registered new interface driver snd-usb-audio
> [ 6.023064] usb 3-6: cannot get ctl value: req = 0x81, wValue = 0x100, wIndex = 0x0, type = 1
> [ 6.023083] usb 3-6: cannot get ctl value: req = 0x81, wValue = 0x202, wIndex = 0x0, type = 4
> [ 6.023090] usb 3-6: cannot get ctl value: req = 0x81, wValue = 0x100, wIndex = 0x0, type = 1
> [ 6.023098] usb 3-6: cannot get ctl value: req = 0x81, wValue = 0x202, wIndex = 0x0, type = 4
> [ 6.023103] usb 3-6: cannot get ctl value: req = 0x81, wValue = 0x100, wIndex = 0x0, type = 1
> [ 6.023110] usb 3-6: cannot get ctl value: req = 0x81, wValue = 0x202, wIndex = 0x0, type = 4
> [ 6.045846] usb 3-6: cannot get ctl value: req = 0x81, wValue = 0x100, wIndex = 0x0, type = 1
> [ 6.045866] usb 3-6: cannot get ctl value: req = 0x81, wValue = 0x202, wIndex = 0x0, type = 4
> [ 6.045877] usb 3-6: cannot get ctl value: req = 0x81, wValue = 0x100, wIndex = 0x0, type = 1
> [ 6.045886] usb 3-6: cannot get ctl value: req = 0x81, wValue = 0x202, wIndex = 0x0, type = 4
> [ 6.045894] usb 3-6: cannot get ctl value: req = 0x81, wValue = 0x100, wIndex = 0x0, type = 1
> [ 6.045908] usb 3-6: cannot get ctl value: req = 0x81, wValue = 0x202, wIndex = 0x0, type = 4
>
> I overlooked the issue because when I was working on the said commit,
> only the front audio is tested. Apology for that.
>
> Changing supports_autosuspend in driver is too late for disabling
> autosuspend, because it was already used by USB probe routine, so it can
> break the balance on the following code that depends on
> supports_autosuspend.
>
> Fix it by using usb_disable_autosuspend() helper, and balance the
> suspend count in disconnect callback.
>
> Fixes: 1965c4364bdd ("ALSA: usb-audio: Disable autosuspend for Lenovo ThinkStation P620")
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
Thanks, applied.
Takashi
next prev parent reply other threads:[~2021-03-04 8:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-04 4:34 [PATCH] ALSA: usb-audio: Disable USB autosuspend properly in setup_disable_autosuspend() Kai-Heng Feng
2021-03-04 8:10 ` Takashi Iwai [this message]
2021-03-04 9:50 ` Joakim Tjernlund
2021-03-04 10:04 ` Kai-Heng Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hh7lrbaq9.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alexander@tsoy.me \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=crwulff@gmail.com \
--cc=dmitry@d-systems.ee \
--cc=dylan_robinson@motu.com \
--cc=gregkh@linuxfoundation.org \
--cc=gustavoars@kernel.org \
--cc=joakim.tjernlund@infinera.com \
--cc=joe@perches.com \
--cc=kai.heng.feng@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=livvy@base.nu \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox