From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD42CC433E1 for ; Sun, 16 Aug 2020 07:51:44 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 37A792065C for ; Sun, 16 Aug 2020 07:51:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="JUAAAsce" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 37A792065C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id A9A3E1655; Sun, 16 Aug 2020 09:50:52 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz A9A3E1655 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1597564302; bh=RfKUOM9sZhQetx6+zlKmiiC7zeCO4qjewwI0g3O8N3s=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=JUAAAsce5++dCE2s7LNNWBFjEpQX0EK3kGeewEHbskOmIK+v0MQBFLZV3PVoIHZ81 ZrVkl7RJDNjMsT9dL+NqjOHcz3uMJFKo+QThHPN3OXA6FOhOM6XOB6WoEvEY2hJypp yl/VdhOCjLk1dIheSEWPSaFXcy3x61HsCvqiLqHU= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 4326AF80228; Sun, 16 Aug 2020 09:50:52 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 51C76F8023F; Sun, 16 Aug 2020 09:50:50 +0200 (CEST) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 2BBD5F800C8 for ; Sun, 16 Aug 2020 09:50:48 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 2BBD5F800C8 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 0A2C4ADC1; Sun, 16 Aug 2020 07:51:12 +0000 (UTC) Date: Sun, 16 Aug 2020 09:50:47 +0200 Message-ID: From: Takashi Iwai To: Brent Lu Subject: Re: [PATCH] ASoC: hdac_hdmi: support 'ELD' mixer In-Reply-To: <20200814083436.19845-1-brent.lu@intel.com> References: <20200814083436.19845-1-brent.lu@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: Guennadi Liakhovetski , alsa-devel@alsa-project.org, Kai Vehmanen , Liam Girdwood , linux-kernel@vger.kernel.org, Pierre-Louis Bossart , Takashi Iwai , Mark Brown , Amadeusz =?UTF-8?B?U8WCYXdpxYRz?= =?UTF-8?B?a2k=?= X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Fri, 14 Aug 2020 10:34:36 +0200, Brent Lu wrote: > @@ -1784,6 +1913,16 @@ int hdac_hdmi_jack_init(struct snd_soc_dai *dai, int device, > } > } > > + /* add control for ELD Bytes */ > + err = hdac_hdmi_create_eld_ctl(component, pcm); > + if (err < 0) { > + dev_err(&hdev->dev, > + "eld control add failed with err: %d for pcm: %d\n", > + err, device); > + kfree(pcm); pcm is allocated vida devm_kzalloc(), hence you shoudn't free it explicitly. thanks, Takashi