From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29805C433E0 for ; Tue, 9 Jun 2020 09:32:21 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A6EE72078D for ; Tue, 9 Jun 2020 09:32:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="ZpqFI5t1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A6EE72078D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 3F67C1694; Tue, 9 Jun 2020 11:31:29 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 3F67C1694 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1591695139; bh=WiWXQpQ2DUG1v/I/+FnuOAn+NbgyfHq9yxp4vRvvHbQ=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=ZpqFI5t1TaOC16RRcQrdPyYYbKu8UolSnCx/cAaafqs8J2B5OAHlAMQm8YGCO8caa XW7+MshMYOVq4va/gtGA9pj8ZcTmmUhpD4Iu3cquZsSWKgfRw5ZdO0pJwA0qNcB1ij cMZJzqB4x/nRHgjUE5J3PVAtaySre8VwouaHVGqM= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id C9DE0F800F1; Tue, 9 Jun 2020 11:31:28 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 14E11F8028C; Tue, 9 Jun 2020 11:31:27 +0200 (CEST) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id BC7DCF800F1 for ; Tue, 9 Jun 2020 11:31:24 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz BC7DCF800F1 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 74A8EAEC3; Tue, 9 Jun 2020 09:31:24 +0000 (UTC) Date: Tue, 09 Jun 2020 11:31:20 +0200 Message-ID: From: Takashi Iwai To: Christoph Hellwig Subject: Re: next-0519 on thinkpad x60: sound related? window manager crash In-Reply-To: <20200609091727.GA23814@lst.de> References: <20200520111136.GA3802@amd> <1591545088.74ii116nf2.none@localhost> <20200608061950.GA17476@lst.de> <1591624340.z01ejtod28.none@localhost> <20200609054306.GA9606@lst.de> <20200609084305.GA21671@lst.de> <20200609091727.GA23814@lst.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org, x86@kernel.org, David Rientjes , tiwai@suse.com, linux-kernel@vger.kernel.org, "Alex Xu \(Hello71\)" , hch@infradead.org, mingo@redhat.com, bp@alien8.de, Pavel Machek , hpa@zytor.com, tglx@linutronix.de X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, 09 Jun 2020 11:17:27 +0200, Christoph Hellwig wrote: > > On Tue, Jun 09, 2020 at 11:09:14AM +0200, Takashi Iwai wrote: > > On Tue, 09 Jun 2020 10:43:05 +0200, > > Christoph Hellwig wrote: > > > > > > On Tue, Jun 09, 2020 at 10:05:26AM +0200, Takashi Iwai wrote: > > > > > >From the disassembly it seems like a vmalloc allocation is NULL, which > > > > > seems really weird as this patch shouldn't make a difference for them, > > > > > and I also only see a single places that allocates the field, and that > > > > > checks for an allocation failure. But the sound code is a little > > > > > hard to unwind sometimes. > > > > > > > > It's not clear which sound device being affected, but if it's > > > > HD-audio on x86, runtime->dma_area points to a vmapped buffer from > > > > SG-pages allocated by dma_alloc_coherent(). > > > > > > > > OTOH, if it's a USB-audio, runtime->dma_area is a buffer by > > > > vmalloc(). > > > > > > Err, you can't just vmap a buffer returned from dma_alloc_coherent, > > > dma_alloc_coherent returns values are opaque and can't be used > > > for virt_to_page. Whatever that code did has already been broken > > > per the DMA API contract and on many architectures and just happend > > > to work on x86 by accident. > > > > Hmm, that's bad. > > > > How would be a proper way to get the virtually mapped SG-buffer pages > > with coherent memory? (Also allowing user-space mmap, too) > > dma_mmap_coherent / dma_mmap_attrs for userspace. We don't really > have a good way for kernel space mappings. And that's the missing piece right now... :-< Takashi