From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [ALSA patch] [PATCH 0/2 v2] Open Alsa dshare without channel binding Date: Wed, 24 Jul 2019 15:20:27 +0200 Message-ID: References: <1563963180-416-1-git-send-email-amiartus@de.adit-jv.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 7CB16F800E3 for ; Wed, 24 Jul 2019 15:20:28 +0200 (CEST) In-Reply-To: <1563963180-416-1-git-send-email-amiartus@de.adit-jv.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" To: Adam Miartus Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org On Wed, 24 Jul 2019 12:12:58 +0200, Adam Miartus wrote: > > The general idea of this patch is to be able to open the device without > defined bindings. As a result, it allows starting the audio clock of > underlying device without blocking a channel. > > This might be useful for creating a dummy dsnoop pcm for hardware that > requires running clock early at system start. This clock is then present > even without application streaming audio data. > > Patch n.1 is intended to check for null pointer of pcm callbacks, > it is not intended to alter any current functionality, properly defined > plugins should not suffer from this change > > Patch n.2 is not intended to alter any current functionality, only > extend it > > V2 of the patch, changes from V1: > - instead of creating new "pcm_unsupported.c" with ops and fast_ops > callbacks returning -ENOSYS, callback == NULL is checked directly > in core implementation and error is returned when pcm has no > callback defined Looks much better now to me. Applied both patches. Thanks! Takashi