From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH] sound: pci: lx6464es: Remove unneeded variable err
Date: Wed, 10 Jul 2019 11:52:52 +0200
Message-ID: <s5hh87urzbf.wl-tiwai@suse.de>
References: <20190710023059.GA14204@hari-Inspiron-1545>
        <s5himsarzh0.wl-tiwai@suse.de>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <s5himsarzh0.wl-tiwai@suse.de>
Sender: linux-kernel-owner@vger.kernel.org
To: Hariprasad Kelam <hariprasad.kelam@gmail.com>
Cc: alsa-devel@alsa-project.org, Thomas Gleixner <tglx@linutronix.de>, Kate Stewart <kstewart@linuxfoundation.org>, Allison Randal <allison@lohutok.net>, Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>, linux-kernel@vger.kernel.org
List-Id: alsa-devel@alsa-project.org

On Wed, 10 Jul 2019 11:49:31 +0200,
Takashi Iwai wrote:
> 
> On Wed, 10 Jul 2019 04:30:59 +0200,
> Hariprasad Kelam wrote:
> > 
> > This patch fixes below issue reported by coccicheck
> > sound/pci/lx6464es/lx6464es.c:256:5-8: Unneeded variable: "err". Return
> > "0" on line 258
> > 
> > We cannot change return value as its registered with snd_pcm_ops->close
> > 
> > Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
> 
> Applied, thanks.

Well, looking at the description above again, I'd drop the text

 "We cannot change return value as its registered with
  snd_pcm_ops->close"

because this is quite misleading.  There is absolutely no need for
changing the function return type.


thanks,

Takashi