From: Takashi Iwai <tiwai@suse.de>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "\"Émeric MASCHINO\"" <emeric.maschino@gmail.com>,
alsa-devel@alsa-project.org
Subject: Re: [PATCH v1] ALSA: fm801: Initialize chip after IRQ handler is registered
Date: Sun, 16 Jul 2017 20:46:30 +0200 [thread overview]
Message-ID: <s5hh8ycb4op.wl-tiwai@suse.de> (raw)
In-Reply-To: <20170716184003.54877-1-andriy.shevchenko@linux.intel.com>
On Sun, 16 Jul 2017 20:40:03 +0200,
Andy Shevchenko wrote:
>
> The commit b56fa687e02b ("ALSA: fm801: detect FM-only card earlier")
> rearranged initialization calls, i.e. it makes snd_fm801_chip_init() to
> be called before we register interrupt handler and set PCI bus
> mastering.
>
> Somehow it prevents FM801-AU to work properly. Thus, partially revert
> initialization order changed by commit mentioned above.
>
> Fixes: b56fa687e02b ("ALSA: fm801: detect FM-only card earlier")
> Reported-by: Émeric MASCHINO <emeric.maschino@gmail.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Applied now with Cc to stable. Thanks.
Takashi
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2017-07-16 18:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-16 18:40 [PATCH v1] ALSA: fm801: Initialize chip after IRQ handler is registered Andy Shevchenko
2017-07-16 18:46 ` Takashi Iwai [this message]
2017-07-16 18:50 ` Takashi Iwai
2017-07-17 19:27 ` Émeric MASCHINO
2017-07-18 10:21 ` Takashi Iwai
2017-07-17 19:20 ` Émeric MASCHINO
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hh8ycb4op.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=emeric.maschino@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox