alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 5/6] pcm:extplug: refinement of masks in extplug
@ 2017-02-17  7:17 sutar.mounesh
  2017-02-17 17:46 ` Takashi Iwai
  0 siblings, 1 reply; 2+ messages in thread
From: sutar.mounesh @ 2017-02-17  7:17 UTC (permalink / raw)
  To: patch; +Cc: Mounesh Sutar, alsa-devel, Awais Belal, mounesh_sutar

From: Awais Belal <awais_belal@mentor.com>

It should be possible to use empty mask format with extplug.
The refinement of mask via extplug is now modified,
to accept empty masks as well to work properly.

Signed-off-by: Awais Belal <awais_belal@mentor.com>
Signed-off-by: Mounesh Sutar <sutar.mounesh@gmail.com>

diff --git a/src/pcm/pcm_extplug.c b/src/pcm/pcm_extplug.c
index a04f826..1004f54 100644
--- a/src/pcm/pcm_extplug.c
+++ b/src/pcm/pcm_extplug.c
@@ -172,6 +172,8 @@ int snd_ext_parm_mask_refine(snd_mask_t *mask, struct snd_ext_parm *parm, int ty
 	unsigned int i;
 
 	parm += type;
+	if (!parm->active)
+		return 0;
 	memset(&bits, 0, sizeof(bits));
 	for (i = 0; i < parm->num_list; i++)
 		bits.bits[parm->list[i] / 32] |= 1U << (parm->list[i] % 32);
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 5/6] pcm:extplug: refinement of masks in extplug
  2017-02-17  7:17 [PATCH 5/6] pcm:extplug: refinement of masks in extplug sutar.mounesh
@ 2017-02-17 17:46 ` Takashi Iwai
  0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2017-02-17 17:46 UTC (permalink / raw)
  To: sutar.mounesh; +Cc: alsa-devel, Awais Belal, mounesh_sutar

On Fri, 17 Feb 2017 08:17:49 +0100,
sutar.mounesh@gmail.com wrote:
> 
> From: Awais Belal <awais_belal@mentor.com>
> 
> It should be possible to use empty mask format with extplug.
> The refinement of mask via extplug is now modified,
> to accept empty masks as well to work properly.
> 
> Signed-off-by: Awais Belal <awais_belal@mentor.com>
> Signed-off-by: Mounesh Sutar <sutar.mounesh@gmail.com>

Applied, thanks.


Takashi

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-02-17 17:46 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-17  7:17 [PATCH 5/6] pcm:extplug: refinement of masks in extplug sutar.mounesh
2017-02-17 17:46 ` Takashi Iwai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).