From: Takashi Iwai <tiwai@suse.de>
To: David Henningsson <david.henningsson@canonical.com>
Cc: alsa-devel@alsa-project.org, 886975@bugs.launchpad.net
Subject: Re: [PATCH] Revert "ALSA: hda - Shut up pins at power-saving mode with Conexnat codecs"
Date: Wed, 19 Dec 2012 11:38:25 +0100 [thread overview]
Message-ID: <s5hhanitjha.wl%tiwai@suse.de> (raw)
In-Reply-To: <50D19846.8060902@canonical.com>
At Wed, 19 Dec 2012 11:34:46 +0100,
David Henningsson wrote:
>
> On 12/19/2012 11:24 AM, Takashi Iwai wrote:
> > At Wed, 19 Dec 2012 09:44:47 +0100,
> > David Henningsson wrote:
> >>
> >> This reverts commit 697c373e34613609cb5450f98b91fefb6e910588.
> >>
> >> The original patch was meant to remove clicking, but in fact caused even
> >> more clicking instead.
> >>
> >> Thanks to c4pp4 for doing most of the work with this bug.
> >>
> >> BugLink: https://bugs.launchpad.net/bugs/886975
> >> Signed-off-by: David Henningsson <david.henningsson@canonical.com>
> >> ---
> >>
> >> @c4pp4: Is this consistent with what you have done to reduce the clicking?
> >> Will you recommend upstream Linux to take the patch below?
> >
> > So, it shouldn't be merged yet right now?
> > Now is the last chance for merging it to 3.8-rc1.
>
> If we don't have time waiting for c4pp4's confirmation without missing
> the entire 3.8 cycle, then I think we should merge it.
It's no new feature, so it's fine to merge it at any time during 3.8
cycle, even after 3.8-rc1.
But such a fix should be merged with Cc to stable, so a bit more tests
would be better.
Takashi
next prev parent reply other threads:[~2012-12-19 10:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-19 8:44 [PATCH] Revert "ALSA: hda - Shut up pins at power-saving mode with Conexnat codecs" David Henningsson
2012-12-19 10:24 ` Takashi Iwai
2012-12-19 10:34 ` David Henningsson
2012-12-19 10:38 ` Takashi Iwai [this message]
2013-01-03 16:04 ` David Henningsson
2013-01-04 8:49 ` Takashi Iwai
2013-01-09 8:36 ` David Henningsson
2013-01-09 10:04 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hhanitjha.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=886975@bugs.launchpad.net \
--cc=alsa-devel@alsa-project.org \
--cc=david.henningsson@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).