Re: Fwd: [PATCH] sound working on the macbook pro

[Takashi Iwai <tiwai@suse.de>]

At Tue, 20 Feb 2007 09:40:35 +0000,
=?UTF-8?Q?Rafael_Esp=C3=ADndola?= wrote:
> 
> > How (and what) does it fail exactly?
> a "diff" of the trace without and with the fix-up is:
> 
> 1) snd_hda_parse_pin_def_config moves the speaker to the line_out
> 2) stac92xx_add_dyn_out_pins adds two line_outs
> 3) stac92xx_auto_create_multi_out_ctls creates the controls "Front",
> "Surround", Center, LFE

OK, this is basically the problem of stac92xx_add_dyn_out_pins() that
it adds surrounds unconditionally.
(BTW, just a curisotiy - would these surround and/or CLFE work as
 outputs?  Or does it have no [mic/line] input jack?)

> 4) stac92xx_auto_create_hp_ctls doesn't run add_spec_dacs or
> create_controls for the speaker. It then creates a control name Master
> instead of Headphone.

Hm, I don't get this yet.  The current auto-config code in
patch_sigmatel isn't 100% suitable for the laptop-style configurations
but rather for the desktop machines.  So, we need a slight redesign of
the configurator at first.  Let's get things straight now.

Please write down the pins you have on your device and what controls
should appear.  I suppose you have

- a HP pin
- a speaker pin
- a mic-in pin

What else?  And, for these controls, we'll have

- Speaker volume/switch
- Headphone volume/switch
- Captuer volume/switch
- Input Mux

but no Master (as STAC codec controls these outputs individually).


> > I'm sure that this would break many other devices.  So, the patch is
> > unacceptable as it is, unfortunately.
> >
> > The line_outs are actually primary outputs, not exactly "line-out".
> > You can find pretty many codes that refer to this as the primary
> > output.
> Do you consider changing this a long term goal? I agree that we should
> first try to get the sound working on the mac book, but the current
> implementation is strange IMHO.

Yes, there is certainly a room for improvements.
For example, we can add another field to indicate what is the primary
output type (line-out, speaker, HP) and stop moving the pin
information itself, so that the check of primary output is kept as
simple as now, and the original information won't be lost.


Takashi

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV