From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4DFA9C433EF for ; Thu, 10 Mar 2022 13:30:57 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 01ADD190C; Thu, 10 Mar 2022 14:30:04 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 01ADD190C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1646919055; bh=O0tJs+it21o/2aLM6+nLsXkd1nRiKeI3cP7ZQY9o7xU=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=LI6oC96ejv8+HufpOd2T2vTAAVKg6DhfTDAV3w1nwxTj+RadhuQ3co1zUCPRJofFa o/LxgtVv/xQq+s/2G1y+utd1PzMqkWTSbN2TNczzDqShDFsrnTy8Z3TKCb1I6imird nTuLGpl+BKf61pmNZ63seJZnCq4ktMnCklm6V9gE= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 849F5F8012F; Thu, 10 Mar 2022 14:30:04 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id E7572F80137; Thu, 10 Mar 2022 14:30:00 +0100 (CET) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 62807F800D2 for ; Thu, 10 Mar 2022 14:29:52 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 62807F800D2 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="uwM/3fmS"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="k1pHIieT" Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 79BA61F381; Thu, 10 Mar 2022 13:29:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1646918991; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=p+BwOJv9TrkOBx6KAoXGGCOccfxsJ7PRbs724DyoEp8=; b=uwM/3fmSXvKY+Y9VgLnmTBZrCkcyUV0lyDO7Uvn35myQ+ZnYD+0j2A4SQDOx6YYB8l1ww6 pzIDPxcA9fK39RKuNNV+Y02rhQwLnUC59H+zsvarGs5HAYBIOe/VGBeVXpOJUxBTgoKUXf XOD09JVtJ98hF2G475XFORRUCVJIc4s= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1646918991; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=p+BwOJv9TrkOBx6KAoXGGCOccfxsJ7PRbs724DyoEp8=; b=k1pHIieTXWKiyI8BKoqkk+7qvSB+TsV7IO8Rmu2PjRSmNXRoHuEgH96OzGQzBDy609VO87 0bWW7t5qSrJXt5Bg== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 0477BA3B88; Thu, 10 Mar 2022 13:29:50 +0000 (UTC) Date: Thu, 10 Mar 2022 14:29:50 +0100 Message-ID: From: Takashi Iwai To: huangwenhui Subject: Re: [PATCH] ALSA: hda/realtek - Fix headset mic problem for a HP machine with alc671 In-Reply-To: <20220310130301.22827-1-huangwenhuia@uniontech.com> References: <20220310130301.22827-1-huangwenhuia@uniontech.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org, kailang@realtek.com, tanureal@opensource.cirrus.com, jeremy.szu@canonical.com, linux-kernel@vger.kernel.org, tiwai@suse.com, wse@tuxedocomputers.com, hui.wang@canonical.com, sami@loone.fi, cam@neo-zeon.de X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, 10 Mar 2022 14:03:01 +0100, huangwenhui wrote: > > On a HP 288 Pro G8, the front Mic could not be detected. > > Signed-off-by: huangwenhui Thanks for the patch. Most of the changes look OK, but one thing I still don't get: > + case HDA_FIXUP_ACT_INIT: > + alc_write_coef_idx(codec, 0x19, 0xa054); > + msleep(80); > + snd_hda_codec_write(codec, hp_pin, 0, > + AC_VERB_SET_AMP_GAIN_MUTE, AMP_OUT_UNMUTE); Why this unconditional unmute is required for fixing the mic problem? Takashi