From: Takashi Iwai <tiwai@suse.de>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: alsa-devel@alsa-project.org, broonie@kernel.org
Subject: Re: [PATCH 1/2] ALSA: drivers: opl3: fix useless self-comparison
Date: Thu, 27 May 2021 08:25:26 +0200 [thread overview]
Message-ID: <s5him348zhl.wl-tiwai@suse.de> (raw)
In-Reply-To: <20210526192957.449515-1-pierre-louis.bossart@linux.intel.com>
On Wed, 26 May 2021 21:29:56 +0200,
Pierre-Louis Bossart wrote:
>
> Sparse throws the following warning:
>
> sound/drivers/opl3/opl3_midi.c:183:60: error: self-comparison always
> evaluates to false
>
> This is likely a 16+ year old confusion between vp2 and vp.
>
> Suggested-by: Takashi Iwai <tiwai@suse.de>
> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Thanks, applied.
Takashi
prev parent reply other threads:[~2021-05-27 6:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-26 19:29 [PATCH 1/2] ALSA: drivers: opl3: fix useless self-comparison Pierre-Louis Bossart
2021-05-26 19:29 ` [PATCH 2/2] ALSA: pci: lx6464es: remove " Pierre-Louis Bossart
2021-05-27 6:25 ` Takashi Iwai
2021-05-27 6:25 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5him348zhl.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).