From: Takashi Iwai <tiwai@suse.de>
To: Andrew Gabbasov <andrew_gabbasov@mentor.com>
Cc: Timo Wischer <twischer@de.adit-jv.com>,
alsa-devel@alsa-project.org, Takashi Iwai <tiwai@suse.com>,
linux-kernel@vger.kernel.org
Subject: Re: [alsa-devel] [PATCH 2/2] ALSA: aloop: Avoid unexpected timer event callback tasklets
Date: Fri, 22 Nov 2019 19:14:06 +0100 [thread overview]
Message-ID: <s5himnb22z5.wl-tiwai@suse.de> (raw)
In-Reply-To: <20191122175218.17187-2-andrew_gabbasov@mentor.com>
On Fri, 22 Nov 2019 18:52:18 +0100,
Andrew Gabbasov wrote:
>
> loopback_snd_timer_close_cable() function waits until all
> scheduled tasklets are completed, but the timer is closed after that
> and can generate more event callbacks, scheduling new tasklets,
> that will not be synchronized with cable closing.
> Move tasklet_kill() call to be executed after snd_timer_close()
> call to avoid such case.
>
> Fixes: 26c53379f98d ("ALSA: aloop: Support selection of snd_timer instead of jiffies")
> Signed-off-by: Andrew Gabbasov <andrew_gabbasov@mentor.com>
Applied, thanks.
Takashi
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2019-11-22 18:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-22 17:52 [alsa-devel] [PATCH 1/2] ALSA: aloop: Remove redundant locking in timer open function Andrew Gabbasov
2019-11-22 17:52 ` [alsa-devel] [PATCH 2/2] ALSA: aloop: Avoid unexpected timer event callback tasklets Andrew Gabbasov
2019-11-22 18:14 ` Takashi Iwai [this message]
2019-11-22 18:13 ` [alsa-devel] [PATCH 1/2] ALSA: aloop: Remove redundant locking in timer open function Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5himnb22z5.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=andrew_gabbasov@mentor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.com \
--cc=twischer@de.adit-jv.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox