From: Takashi Iwai <tiwai@suse.de>
To: Hariprasad Kelam <hariprasad.kelam@gmail.com>
Cc: alsa-devel@alsa-project.org, Thomas Gleixner <tglx@linutronix.de>,
Kate Stewart <kstewart@linuxfoundation.org>,
Allison Randal <allison@lohutok.net>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sound: pci: lx6464es: Remove unneeded variable err
Date: Wed, 10 Jul 2019 11:49:31 +0200 [thread overview]
Message-ID: <s5himsarzh0.wl-tiwai@suse.de> (raw)
In-Reply-To: <20190710023059.GA14204@hari-Inspiron-1545>
On Wed, 10 Jul 2019 04:30:59 +0200,
Hariprasad Kelam wrote:
>
> This patch fixes below issue reported by coccicheck
> sound/pci/lx6464es/lx6464es.c:256:5-8: Unneeded variable: "err". Return
> "0" on line 258
>
> We cannot change return value as its registered with snd_pcm_ops->close
>
> Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
Applied, thanks.
Takashi
next prev parent reply other threads:[~2019-07-10 9:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-10 2:30 [PATCH] sound: pci: lx6464es: Remove unneeded variable err Hariprasad Kelam
2019-07-10 9:49 ` Takashi Iwai [this message]
2019-07-10 9:52 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5himsarzh0.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=allison@lohutok.net \
--cc=alsa-devel@alsa-project.org \
--cc=hariprasad.kelam@gmail.com \
--cc=kstewart@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tglx@linutronix.de \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox