From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH v2 1/2] ALSA: hda/hdmi - Read the pin sense from register when repolling Date: Mon, 06 May 2019 16:31:15 +0200 Message-ID: References: <20190506140932.7942-1-hui.wang@canonical.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id B0FBAF80C07 for ; Mon, 6 May 2019 16:31:16 +0200 (CEST) In-Reply-To: <20190506140932.7942-1-hui.wang@canonical.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" To: Hui Wang Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org On Mon, 06 May 2019 16:09:31 +0200, Hui Wang wrote: > > @@ -1663,6 +1663,11 @@ static void hdmi_repoll_eld(struct work_struct *work) > container_of(to_delayed_work(work), struct hdmi_spec_per_pin, work); > struct hda_codec *codec = per_pin->codec; > struct hdmi_spec *spec = codec->spec; > + struct hda_jack_tbl *jack; > + > + jack = snd_hda_jack_tbl_get(codec, per_pin->pin_nid); > + if (jack) > + jack = jack->jack_dirty = 1; Oh, and I corrected the obvious typo above manually while applying. We don't need to substitute jack twice. Takashi