Re: [PATCH 4/4] ALSA: hda - hdmi monitor hotplug support for dynamic pcm assignment

[Takashi Iwai <tiwai@suse.de>]

On Thu, 31 Dec 2015 02:22:22 +0100,
libin.yang@linux.intel.com wrote:
> 
> From: Libin Yang <libin.yang@linux.intel.com>
> 
> This patch adds the support for monitor hotplug of dynamic pcm assignment.
> 
> 1. unsol_event enabling
>  - For codec_has_acomp, unsol_event is disabled.
>  - For !codec_has_acomp && !dyn_pcm_assign, use the hda_jack helper to
>    enable unsol_event
>  - For !codec_has_acomp && dyn_pcm_assign, enable unsol_event with verb
>    directly
> 
> 2. unsol_event handling
>  - For !dyn_pcm_assign, use hda_jack helper to report the event
>  - For dyn_pcm_assign, use snd_jack_report() directly

I guess we can reduce lots of codes if ignoring the case with
dyn_pcm_assign but without audio component?  If so, for simplicity, we
can limit dyn_pcm_assign only tied with audio component.  Just add a
WARN_ON() in such a case.  Although the functionality is somehow
unrelated, the actual testing and coding is more targeted with Intel
chips that are only with audio component.


Takashi