From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH v2 1/2] ASoC: soc-compress: add a config
	item for soc-compress
Date: Tue, 16 Jun 2015 18:17:12 +0200
Message-ID: <s5hioan8w6v.wl-tiwai@suse.de>
References: <1434338445-31992-1-git-send-email-yang.jie@intel.com>
 <s5hmw01gq9c.wl-tiwai@suse.de>
 <E7B1D079BA13FB44A978CC8F69C7D6A90554AA25@SHSMSX101.ccr.corp.intel.com>
 <s5h4mm9gi8h.wl-tiwai@suse.de>
 <E7B1D079BA13FB44A978CC8F69C7D6A90554AA81@SHSMSX101.ccr.corp.intel.com>
 <20150615150556.GQ18309@sirena.org.uk>
 <E7B1D079BA13FB44A978CC8F69C7D6A90554ACF5@SHSMSX101.ccr.corp.intel.com>
 <20150616105429.GI18309@sirena.org.uk>
 <E7B1D079BA13FB44A978CC8F69C7D6A90554B0BF@SHSMSX101.ccr.corp.intel.com>
 <20150616160607.GT18309@sirena.org.uk>
 <s5hlhfj8wb3.wl-tiwai@suse.de>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15])
 by alsa0.perex.cz (Postfix) with ESMTP id 4FC2426585A
 for <alsa-devel@alsa-project.org>; Tue, 16 Jun 2015 18:17:12 +0200 (CEST)
In-Reply-To: <s5hlhfj8wb3.wl-tiwai@suse.de>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/options/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel/>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Errors-To: alsa-devel-bounces@alsa-project.org
Sender: alsa-devel-bounces@alsa-project.org
To: Mark Brown <broonie@kernel.org>
Cc: "ramesh.babu@linux.intel.com" <ramesh.babu@linux.intel.com>, "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>, "Koul,
 Vinod" <vinod.koul@intel.com>, "Zhang, Vivian" <vivian.zhang@intel.com>, "Girdwood, Liam R" <liam.r.girdwood@intel.com>
List-Id: alsa-devel@alsa-project.org

At Tue, 16 Jun 2015 18:14:40 +0200,
Takashi Iwai wrote:
> 
> At Tue, 16 Jun 2015 17:06:07 +0100,
> Mark Brown wrote:
> > 
> > On Tue, Jun 16, 2015 at 12:36:16PM +0000, Jie, Yang wrote:
> > 
> > > > OK, that should have been in the commit message.
> > 
> > > OK, so let me add it to the commit message and resend?
> > 
> > Well, there's still the stubs to consider.  Should we really be
> > returning an error or should we silently ignore the error and hide the
> > DAI if the user deconfigured compressed audio?  Or rearrange things so
> > we don't need stubs?  Given that the machine driver has to select
> > compressed support it's not something that should ever really hit the
> > stubs, it's not truly a runtime thing...
> 
> Yes, I guess that leaving without dummy function will give unresolved
> symbol errors at module link time, so the user can catch before
> actually running it.  Of course, this should be checked actually.

Oh, scratch this.  It won't work well in the current code.
Possibly with weak linking, but...


Takashi