From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH v2 3/3] ALSA: topology: Export ID types for TLV controls. Date: Thu, 28 May 2015 16:59:35 +0200 Message-ID: References: <1432574570-7436-1-git-send-email-liam.r.girdwood@linux.intel.com> <1432574570-7436-3-git-send-email-liam.r.girdwood@linux.intel.com> <1432824456.2726.46.camel@loki> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 4ABFC2604BE for ; Thu, 28 May 2015 16:59:36 +0200 (CEST) In-Reply-To: <1432824456.2726.46.camel@loki> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Liam Girdwood Cc: alsa-devel@alsa-project.org, Mark Brown List-Id: alsa-devel@alsa-project.org At Thu, 28 May 2015 15:47:36 +0100, Liam Girdwood wrote: > > On Mon, 2015-05-25 at 18:22 +0100, Liam Girdwood wrote: > > Make sure userspace can define TLV controls for topolofy using the correct > > type numbers. > > > > Signed-off-by: Liam Girdwood > > --- > > include/sound/tlv.h | 7 +------ > > include/uapi/sound/tlv.h | 23 +++++++++++++++++++++++ > > 2 files changed, 24 insertions(+), 6 deletions(-) > > create mode 100644 include/uapi/sound/tlv.h > > > > diff --git a/include/sound/tlv.h b/include/sound/tlv.h > > Takashi, do you want this rolled into uapi/sound/asound.h or is it fine > as a separate file ? I think uapi/sound/tlv.h is fine. But don't forget to export other consts. For example, SNDRV_CTL_TLVT_CHMAP_* are also reserved for channel-maps. thanks, Takashi