From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH 021/102] ASoC: ssm2602: Omit superfluous
	elements in input select array
Date: Tue, 18 Feb 2014 14:29:15 +0100
Message-ID: <s5hioscy2fo.wl%tiwai@suse.de>
References: <1392723422-12689-1-git-send-email-tiwai@suse.de>
 <1392723422-12689-6-git-send-email-tiwai@suse.de>
 <53034B23.703@metafoo.de> <1392729807.2304.29.camel@loki>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15])
 by alsa0.perex.cz (Postfix) with ESMTP id B3886265904
 for <alsa-devel@alsa-project.org>; Tue, 18 Feb 2014 14:29:15 +0100 (CET)
In-Reply-To: <1392729807.2304.29.camel@loki>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/options/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel/>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Errors-To: alsa-devel-bounces@alsa-project.org
Sender: alsa-devel-bounces@alsa-project.org
To: Liam Girdwood <liam.r.girdwood@intel.com>
Cc: alsa-devel@alsa-project.org, Lars-Peter Clausen <lars@metafoo.de>, Mark Brown <broonie@kernel.org>, Liam Girdwood <lgirdwood@gmail.com>
List-Id: alsa-devel@alsa-project.org

At Tue, 18 Feb 2014 13:23:27 +0000,
Liam Girdwood wrote:
> 
> On Tue, 2014-02-18 at 12:59 +0100, Lars-Peter Clausen wrote:
> > On 02/18/2014 12:36 PM, Takashi Iwai wrote:
> > > The array contains too many elements although it should have only
> > > two.
> > >
> > > Signed-off-by: Takashi Iwai <tiwai@suse.de>
> > > ---
> > >   sound/soc/codecs/ssm2602.c | 9 +++++----
> > >   1 file changed, 5 insertions(+), 4 deletions(-)
> > >
> > > diff --git a/sound/soc/codecs/ssm2602.c b/sound/soc/codecs/ssm2602.c
> > > index f444d585b916..e32b82ff6304 100644
> > > --- a/sound/soc/codecs/ssm2602.c
> > > +++ b/sound/soc/codecs/ssm2602.c
> > > @@ -75,15 +75,16 @@ static const u16 ssm2602_reg[SSM2602_CACHEREGNUM] = {
> > >
> > >   /*Appending several "None"s just for OSS mixer use*/
> > >   static const char *ssm2602_input_select[] = {
> > > -	"Line", "Mic", "None", "None", "None",
> > > -	"None", "None", "None",
> > > +	"Line", "Mic",
> > >   };
> > 
> > I never dared to change it because of the comment above the array. I must 
> > admit that I have no idea though why those extra None entries are necessary 
> > for OSS.
> 
> iirc the OSS input mixer in userspace may expect a similar number of
> entries to be compatible with the old Soundblaster16 input mixer ?

But this array is referred as having only two elements,

	SOC_ENUM_SINGLE(SSM2602_APANA, 2, 2, ssm2602_input_select),

so the OSS access (via emulation) won't take more than two, either.


Takashi