From: Takashi Iwai <tiwai@suse.de>
To: Imre Deak <imre.deak@intel.com>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Clemens Ladisch <clemens@ladisch.de>,
Jaroslav Kysela <perex@perex.cz>,
alsa-devel@alsa-project.org
Subject: Re: [PATCH v2 8/8] sound/oxygen_io: take msecs_to_jiffies_timeout into use
Date: Tue, 14 May 2013 16:50:56 +0200 [thread overview]
Message-ID: <s5hip2lobsf.wl%tiwai@suse.de> (raw)
In-Reply-To: <1368542918-8861-9-git-send-email-imre.deak@intel.com>
At Tue, 14 May 2013 17:48:38 +0300,
Imre Deak wrote:
>
> Use msecs_to_jiffies_timeout instead of open-coding the same.
>
> Signed-off-by: Imre Deak <imre.deak@intel.com>
Acked-by: Takashi Iwai <tiwai@suse.de>
Takashi
> ---
> sound/pci/oxygen/oxygen_io.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/pci/oxygen/oxygen_io.c b/sound/pci/oxygen/oxygen_io.c
> index 521eae4..51bfcd0 100644
> --- a/sound/pci/oxygen/oxygen_io.c
> +++ b/sound/pci/oxygen/oxygen_io.c
> @@ -108,7 +108,7 @@ static int oxygen_ac97_wait(struct oxygen *chip, unsigned int mask)
> wait_event_timeout(chip->ac97_waitqueue,
> ({ status |= oxygen_read8(chip, OXYGEN_AC97_INTERRUPT_STATUS);
> status & mask; }),
> - msecs_to_jiffies(1) + 1);
> + msecs_to_jiffies_timeout(1));
> /*
> * Check even after a timeout because this function should not require
> * the AC'97 interrupt to be enabled.
> --
> 1.7.10.4
>
prev parent reply other threads:[~2013-05-14 14:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1368542918-8861-1-git-send-email-imre.deak@intel.com>
[not found] ` <1368188011-23661-1-git-send-email-imre.deak@intel.com>
2013-05-10 12:13 ` [PATCH 11/11] sound/oxygen_io: take msecs_to_jiffies_min into use Imre Deak
2013-05-13 14:00 ` Takashi Iwai
2013-05-13 14:24 ` Imre Deak
2013-05-13 14:35 ` Takashi Iwai
2013-05-13 14:30 ` Clemens Ladisch
2013-05-14 14:48 ` [PATCH v2 8/8] sound/oxygen_io: take msecs_to_jiffies_timeout " Imre Deak
2013-05-14 14:50 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hip2lobsf.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=akpm@linux-foundation.org \
--cc=alsa-devel@alsa-project.org \
--cc=clemens@ladisch.de \
--cc=daniel.vetter@ffwll.ch \
--cc=imre.deak@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox