Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: M G <lists.mg@googlemail.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: snd-hda-intel: Fix volume-wheel and microphone on	Fujitsu-Siemens Amilo M3438G
Date: Fri, 07 Mar 2008 13:12:39 +0100	[thread overview]
Message-ID: <s5hiqzy20nc.wl%tiwai@suse.de> (raw)
In-Reply-To: <74d457500803060915y682558fancca3691d5abd340d@mail.gmail.com>

At Thu, 6 Mar 2008 18:15:32 +0100,
M G wrote:
> 
> On Mon, Feb 11, 2008 at 2:51 PM, Takashi Iwai <tiwai@suse.de> wrote:
> >
> >  OK, now applied to HG tree.  Thanks.
> >
> >
> >  Takashi
> >
> 
> 
> 
> It has already been a great improvement but I encountered 2 more problems:
> 
> On first use (i.e. when loading the module for the first time after
> compiling it) the mixer displayed Mic as capture source but I couldn't
> capture anything. When I switch to CD and then back to Mic it starts
> working. It seems that the value is initialized to 0x00 but there is
> no corresponding capture device on this model since the mic is 0x01 so
> it needs to be initialized to 0x01.
> 
> Another thing: I can set the capture volume to a maximum of 14dB.
> Above that the quality starts to degrade rapidly and at about 17dB it
> goes completely dead. With VREF50 I can raise the capture all the way
> up to 35dB.

Thanks for the patch.  Could you give your sign-off together with a
proper changelog to commit to the upstream?


Takashi


> 
> diff -r 72360e8993f7 pci/hda/patch_realtek.c
> --- a/pci/hda/patch_realtek.c	Thu Mar 06 16:58:35 2008 +0100
> +++ b/pci/hda/patch_realtek.c	Thu Mar 06 17:37:22 2008 +0100
> @@ -1927,6 +1927,7 @@ static void alc880_uniwill_p53_unsol_eve
>   * HP = 0x14, speaker-out = 0x15, mic = 0x18
>   */
>  static struct hda_verb alc880_pin_f1734_init_verbs[] = {
> +	{0x07, AC_VERB_SET_CONNECT_SEL, 0x01},
>  	{0x10, AC_VERB_SET_CONNECT_SEL, 0x02},
>  	{0x11, AC_VERB_SET_CONNECT_SEL, 0x00},
>  	{0x12, AC_VERB_SET_CONNECT_SEL, 0x01},
> @@ -1939,7 +1940,7 @@ static struct hda_verb alc880_pin_f1734_
> 
>  	{0x18, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_VREF80},
>  	{0x18, AC_VERB_SET_AMP_GAIN_MUTE, AMP_OUT_MUTE},
> -	{0x19, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_VREF80},
> +	{0x19, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_VREF50},
>  	{0x19, AC_VERB_SET_AMP_GAIN_MUTE, AMP_OUT_MUTE},
>  	{0x1a, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_OUT},
>  	{0x1a, AC_VERB_SET_AMP_GAIN_MUTE, AMP_OUT_UNMUTE},
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
> 

  reply	other threads:[~2008-03-07 12:12 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-06 16:14 snd-hda-intel: Fix volume-wheel and microphone on Fujitsu-Siemens Amilo M3438G M G
2008-02-06 16:36 ` Takashi Iwai
2008-02-06 23:02   ` M G
2008-02-08 11:54     ` Takashi Iwai
2008-02-10 18:48       ` M G
2008-02-11 13:51         ` Takashi Iwai
2008-03-06 17:15           ` M G
2008-03-07 12:12             ` Takashi Iwai [this message]
2008-03-09 10:37               ` M G
2008-03-10 10:25                 ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hiqzy20nc.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=lists.mg@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox