Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Liam Girdwood <liam.girdwood@wolfsonmicro.com>
Cc: alsa-devel <alsa-devel@lists.sourceforge.net>
Subject: Re: [PATCH 2/8] ASoC pxa2xx I2S support
Date: Tue, 10 Oct 2006 19:06:59 +0200	[thread overview]
Message-ID: <s5hirism764.wl%tiwai@suse.de> (raw)
In-Reply-To: <1160496714.24436.111.camel@localhost.localdomain>

At Tue, 10 Oct 2006 17:11:54 +0100,
Liam Girdwood wrote:
> 
> +/* used to disable sysclk if external crystal is used */
> +static int extclk = 0;

You can omit "= 0" for zero-initialization of a static variable.

> +static int pxa2xx_i2s_hw_params(struct snd_pcm_substream *substream,
> +				struct snd_pcm_hw_params *params)
> +{
> +	struct snd_soc_pcm_runtime *rtd = substream->private_data;
> +
> +	pxa_i2s.master = 0;
> +	if (rtd->cpu_dai->dai_runtime.fmt & SND_SOC_DAIFMT_CBS_CFS)
> +		pxa_i2s.master = 1;
> +
> +	if (pxa_i2s.master && !extclk) {
> +		pxa_gpio_mode(gpio_bus[pxa_i2s.master].sys);
> +	}

Remove braces.


Takashi

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

  reply	other threads:[~2006-10-10 17:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-10 16:11 [PATCH 2/8] ASoC pxa2xx I2S support Liam Girdwood
2006-10-10 17:06 ` Takashi Iwai [this message]
2006-10-12 10:14   ` Liam Girdwood
2006-10-12 10:56     ` Takashi Iwai
2006-10-12 15:47       ` Nicolas Pitre
2006-10-12 17:18         ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hirism764.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@lists.sourceforge.net \
    --cc=liam.girdwood@wolfsonmicro.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox