From: Takashi Iwai <tiwai@suse.de>
To: "Tien, C.L." <cltien@cmedia.com.tw>
Cc: alsa-devel@alsa-project.org
Subject: Re: PCI_D0 and PCI_D3hot in atiixp_modem.c not defined in pci.h
Date: Wed, 13 Apr 2005 15:08:53 +0200 [thread overview]
Message-ID: <s5his2q7riy.wl@alsa2.suse.de> (raw)
In-Reply-To: <s5hk6n67rpg.wl@alsa2.suse.de>
[-- Attachment #1: Type: text/plain, Size: 463 bytes --]
At Wed, 13 Apr 2005 15:04:59 +0200,
I wrote:
>
> [1 <text/plain; US-ASCII (7bit)>]
> At Wed, 13 Apr 2005 07:53:07 +0800,
> Tien, C.L. wrote:
> >
> > Hi,
> >
> > The CVS version of atiixp_modem.c use PCI_D0 and PCI_D3hot. These
> > constants are not defined in pci.h before kernel version 2.6.11,
> > compile the file will cause compile error as following:
>
> The patch below should fix this problem.
This one is safer...
I'll apply this to CVS.
Takashi
[-- Attachment #2: Type: text/plain, Size: 1019 bytes --]
Index: alsa-driver/include/adriver.h
===================================================================
RCS file: /home/iwai/cvs/alsa/alsa-driver/include/adriver.h,v
retrieving revision 1.108
retrieving revision 1.110
diff -u -r1.108 -r1.110
--- alsa-driver/include/adriver.h 11 Apr 2005 15:54:49 -0000 1.108
+++ alsa-driver/include/adriver.h 13 Apr 2005 13:07:29 -0000 1.110
@@ -80,14 +80,6 @@
#endif
#endif /* LINUX_2_2 */
-#ifndef PCI_D0
-#define PCI_D0 0
-#define PCI_D1 1
-#define PCI_D2 2
-#define PCI_D3hot 3
-#define PCI_D3cold 4
-#endif
-
#ifdef LINUX_2_4__donotuse
#include <linux/init.h>
#include <linux/pm.h>
@@ -732,6 +724,19 @@
#endif
#endif
+#if LINUX_VERSION_CODE < KERNEL_VERSION(2, 6, 11)
+#ifdef CONFIG_PCI
+#include <linux/pci.h>
+#ifndef PCI_D0
+#define PCI_D0 0
+#define PCI_D1 1
+#define PCI_D2 2
+#define PCI_D3hot 3
+#define PCI_D3cold 4
+#endif
+#endif
+#endif
+
/* vprintk */
#if LINUX_VERSION_CODE < KERNEL_VERSION(2, 6, 9)
#include <linux/kernel.h>
prev parent reply other threads:[~2005-04-13 13:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-12 23:53 PCI_D0 and PCI_D3hot in atiixp_modem.c not defined in pci.h "Tien, C.L. - 田承禮"
2005-04-13 13:04 ` Takashi Iwai
2005-04-13 13:08 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5his2q7riy.wl@alsa2.suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=cltien@cmedia.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox