From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [2.6 patch] ALSA ISA drivers: misc cleanups Date: Thu, 25 Nov 2004 16:20:30 +0100 Message-ID: References: <20041124232758.GP19873@stusta.de> Mime-Version: 1.0 (generated by SEMI 1.14.5 - "Awara-Onsen") Content-Type: text/plain; charset=US-ASCII Return-path: Received: from Cantor.suse.de (cantor.suse.de [195.135.220.2]) by alsa.alsa-project.org (ALSA's E-mail Delivery System) with ESMTP id C463D198 for ; Thu, 25 Nov 2004 16:20:32 +0100 (MET) In-Reply-To: <20041124232758.GP19873@stusta.de> Sender: alsa-devel-admin@lists.sourceforge.net Errors-To: alsa-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: To: Adrian Bunk Cc: perex@suse.cz, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org List-Id: alsa-devel@alsa-project.org At Thu, 25 Nov 2004 00:27:58 +0100, Adrian Bunk wrote: > > The patch below makes cleanups under sound/isa/ including: > - make needlessly global code static > - ad1816a/ad1816a_lib.c: much code was unused starting with the > global function snd_ad1816a_timer I prefer disabling this to removal (in case somone wants to add the timer function). > - removed EXPORT_SYMBOL's: > - cs423x/cs4231_lib.c: snd_cs4231_outm > - es1688/es1688_lib.c: snd_es1688_mixer_read > > Please review this patch. Otherwise looks fine. Applied it to ALSA tree. Thanks! Takashi ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://productguide.itmanagersjournal.com/