From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: 2.6.10-rc2 on VAIO laptop and PowerMac 8500/G3 Date: Mon, 22 Nov 2004 12:58:02 +0100 Message-ID: References: <20041120185100.GA1205@elf.ucw.cz> <1100977903.6879.56.camel@krustophenia.net> Mime-Version: 1.0 (generated by SEMI 1.14.5 - "Awara-Onsen") Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: <1100977903.6879.56.camel@krustophenia.net> Sender: alsa-devel-admin@lists.sourceforge.net Errors-To: alsa-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: To: Lee Revell Cc: Pavel Machek , John Mock , linux-kernel@vger.kernel.org, perex@suse.cz, alsa-devel List-Id: alsa-devel@alsa-project.org At Sat, 20 Nov 2004 14:11:42 -0500, Lee Revell wrote: > > Please cc: alsa-devel on ALSA issues (we now allow posts from non > subscribers! :-P). It's a known problem and already fixed on ALSA CVS. Sice 2.6.10-rc2, pci_save_state() is no longer called as default when suspend callback is set. The patch is below. Takashi --- linux/sound/core/init.c 8 Nov 2004 11:37:08 -0000 1.48 +++ linux/sound/core/init.c 12 Nov 2004 13:56:32 -0000 @@ -782,12 +782,15 @@ int snd_card_pci_suspend(struct pci_dev *dev, u32 state) { snd_card_t *card = pci_get_drvdata(dev); + int err; if (! card || ! card->pm_suspend) return 0; if (card->power_state == SNDRV_CTL_POWER_D3hot) return 0; /* FIXME: correct state value? */ - return card->pm_suspend(card, 0); + err = card->pm_suspend(card, 0); + pci_save_state(dev); + return err; } int snd_card_pci_resume(struct pci_dev *dev) ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://productguide.itmanagersjournal.com/