From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9A05C54FCB for ; Fri, 24 Apr 2020 12:42:25 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4611120704 for ; Fri, 24 Apr 2020 12:42:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="hf9VeoF4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4611120704 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id A251F16B4; Fri, 24 Apr 2020 14:41:33 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz A251F16B4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1587732143; bh=xTbPbOMEBENl0h3StC1WBHP2Aw+Z7DPMDw/3Sd38p5U=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=hf9VeoF484F9/yPPQEQjEt7x6gh8YMd62WppXtqVvNanKj/ab1/lkD5U5LOARi5M6 0/8GTMEYfyq1v7BUEW8RUuxldq+0OfiBsU/RBHQtaJW9qtSHH7uNgimmIqc3IFVHrC C4oV2xoeZ08hZTdVSWKiia0J84bT8R+vWxq48+ec= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 3B16BF80116; Fri, 24 Apr 2020 14:41:33 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 316A4F80142; Fri, 24 Apr 2020 14:41:31 +0200 (CEST) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 307C1F80116 for ; Fri, 24 Apr 2020 14:41:18 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 307C1F80116 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 84C15AD0F; Fri, 24 Apr 2020 12:41:17 +0000 (UTC) Date: Fri, 24 Apr 2020 14:41:17 +0200 Message-ID: From: Takashi Iwai To: Kai Vehmanen Subject: Re: [PATCH] ASoC: snd-sof-intel-hda-common - add hda_model parameter and pass it to HDA codec driver In-Reply-To: References: <20200424092520.23989-1-perex@perex.cz> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: ALSA development , Mark Brown , Pierre-Louis Bossart X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Fri, 24 Apr 2020 14:24:30 +0200, Kai Vehmanen wrote: > > Hey, > > On Fri, 24 Apr 2020, Jaroslav Kysela wrote: > > > It may be useful to pass the specific model to the generic HDA codec > > routines like the legacy HDA driver (snd-hda-intel) allows. > [...] > > Original proposal: https://lore.kernel.org/alsa-devel/20191203161908.7496-1-perex@perex.cz/ > > not sure why this got stuck last year, but seems like a welcome > addition: > > Reviewed-by: Kai Vehmanen > > > The model name "sofbus" is tricky anyway. > > Hmm, I wonder is this now doing more harm than good. Based on browsing > through the related code in hda-codec.c and friends, it would seem > "sofbus" as the default is mostly harmless, but I could have missed > something. That's currently harmless since no codec driver defines "sofbus" model, hence the HDA parser continues to match with the default quirks. OTOH, the fixed "sofbus" model is fairly useless. So, feel free to take my ack, too: Reviewed-by: Takashi Iwai thanks, Takashi