From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH] ALSA: firewire: arrange common PCM info/constraints for AMDTP engine applications Date: Thu, 08 Jun 2017 09:16:40 +0200 Message-ID: References: <20170608001103.28870-1-o-takashi@sakamocchi.jp> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 990F92671CA for ; Thu, 8 Jun 2017 09:16:41 +0200 (CEST) In-Reply-To: <20170608001103.28870-1-o-takashi@sakamocchi.jp> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Takashi Sakamoto Cc: alsa-devel@alsa-project.org, clemens@ladisch.de, ffado-devel@lists.sf.net List-Id: alsa-devel@alsa-project.org On Thu, 08 Jun 2017 02:11:03 +0200, Takashi Sakamoto wrote: > > In ALSA firewire stack, 8 drivers uses IEC 61883-1/6 engine for data > transmission. They have common PCM info/constraints and duplicated codes. > > This commit unifies the codes into fireiwre-lib. > > Signed-off-by: Takashi Sakamoto > --- > sound/firewire/amdtp-stream.c | 19 +++++++++++++++++ > sound/firewire/bebob/bebob_pcm.c | 21 ------------------- > sound/firewire/dice/dice-pcm.c | 20 ------------------ > sound/firewire/digi00x/digi00x-pcm.c | 33 ++++++++++-------------------- > sound/firewire/fireface/ff-pcm.c | 21 ------------------- > sound/firewire/fireworks/fireworks_pcm.c | 21 ------------------- > sound/firewire/motu/motu-pcm.c | 20 ------------------ > sound/firewire/oxfw/oxfw-pcm.c | 20 ------------------ > sound/firewire/tascam/tascam-pcm.c | 35 ++++++-------------------------- > 9 files changed, 36 insertions(+), 174 deletions(-) Lovely, lots of code reduction. Applied now. Thanks. Takashi