From: Takashi Iwai <tiwai@suse.de>
To: Julian Scheel <julian@jusst.de>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] ALSA: usb-audio: Fix parameter block size for UAC2 control requests
Date: Fri, 14 Aug 2015 15:51:00 +0200 [thread overview]
Message-ID: <s5hk2syt1vf.wl-tiwai@suse.de> (raw)
In-Reply-To: <55CDF116.8070400@jusst.de>
On Fri, 14 Aug 2015 15:45:58 +0200,
Julian Scheel wrote:
>
> Am 14.08.2015 um 15:17 schrieb Takashi Iwai:
> > On Thu, 13 Aug 2015 13:04:46 +0200,
> > Julian Scheel wrote:
> >>
> >> @@ -469,6 +503,8 @@ int snd_usb_mixer_set_ctl_value(struct usb_mixer_elem_info *cval,
> >> value_set = convert_bytes_value(cval, value_set);
> >> buf[0] = value_set & 0xff;
> >> buf[1] = (value_set >> 8) & 0xff;
> >> + buf[2] = (value_set >> 16) & 0xff;
> >> + buf[3] = (value_set >> 24) & 0xff;
> >
> > It's not smart but OK, just a subtle matter...
>
> Hm, what would you like better?
A shorter code would be to to pass __le32 value pointer directly after
calling cpu_to_le32(), for example. But it's a matter of taste, so
it's OK to keep your code as is.
Takashi
next prev parent reply other threads:[~2015-08-14 13:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-13 11:04 [PATCH] ALSA: usb-audio: Fix parameter block size for UAC2 control requests Julian Scheel
2015-08-14 13:17 ` Takashi Iwai
2015-08-14 13:45 ` Julian Scheel
2015-08-14 13:51 ` Takashi Iwai [this message]
2015-08-14 14:14 ` Julian Scheel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hk2syt1vf.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=julian@jusst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox