From: Takashi Iwai <tiwai@suse.de>
To: Kailang <kailang@realtek.com>
Cc: " (alsa-devel@alsa-project.org)" <alsa-devel@alsa-project.org>
Subject: Re: ALC298 headset mode support
Date: Mon, 11 May 2015 14:34:53 +0200 [thread overview]
Message-ID: <s5hk2wfgumq.wl-tiwai@suse.de> (raw)
In-Reply-To: <6FAB7C47BCF00940BB0999A99BE3547A17A10470@RTITMBSV09.realtek.com.tw>
At Mon, 11 May 2015 08:30:28 +0000,
Kailang wrote:
>
> Hi Takashi,
>
> I finished the alc298 headset mode supported.
> But it only tested via our develop system.
....
> @@ -3801,6 +3804,8 @@ static void alc_headset_mode_ctia(struct hda_codec *codec)
> case 0x10ec0283:
> alc_process_coef_fw(codec, coef0233);
> break;
> + case 0x10ec0298:
> + alc_update_coef_idx(codec, 0x8e, 0x0070, 0x0020);
> case 0x10ec0286:
I suppose you didn't forget break in the above, right?
If so, add a comment like /* fallthrough */ to indicate that it's the
intentional code. Ditto for other similar lines.
thanks,
Takashi
next parent reply other threads:[~2015-05-11 12:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <6FAB7C47BCF00940BB0999A99BE3547A17A10470@RTITMBSV09.realtek.com.tw>
2015-05-11 12:34 ` Takashi Iwai [this message]
[not found] ` <6FAB7C47BCF00940BB0999A99BE3547A17A105CC@RTITMBSV09.realtek.com.tw>
2015-05-12 11:16 ` ALC298 headset mode support Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hk2wfgumq.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=kailang@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox