From: Takashi Iwai <tiwai@suse.de>
To: Vinod Koul <vinod.koul@intel.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] ALSA: compress: Fix 64bit ABI incompatibility
Date: Mon, 16 Dec 2013 09:43:58 +0100 [thread overview]
Message-ID: <s5hk3f5uqwh.wl%tiwai@suse.de> (raw)
In-Reply-To: <20131215135740.GT29580@intel.com>
At Sun, 15 Dec 2013 19:27:40 +0530,
Vinod Koul wrote:
>
> On Tue, Dec 10, 2013 at 03:33:17PM +0100, Takashi Iwai wrote:
> > snd_pcm_uframes_t is defined as unsigned long so it would take
> > different sizes depending on 32 or 64bit architectures. As we don't
> > want this ABI incompatibility, and there is no real 64bit user yet,
> > let's make it the fixed size with __u32.
> >
> > Also bump the protocol version number to 0.1.2.
>
> Was this applied?
Yes.
Takashi
>
> >
> > Acked-by: Vinod Koul <vinod.koul@intel.com>
> > Cc: <stable@vger.kernel.org>
> > Signed-off-by: Takashi Iwai <tiwai@suse.de>
> > ---
> > include/uapi/sound/compress_offload.h | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/include/uapi/sound/compress_offload.h b/include/uapi/sound/compress_offload.h
> > index d630163b9a2e..5759810e1c1b 100644
> > --- a/include/uapi/sound/compress_offload.h
> > +++ b/include/uapi/sound/compress_offload.h
> > @@ -30,7 +30,7 @@
> > #include <sound/compress_params.h>
> >
> >
> > -#define SNDRV_COMPRESS_VERSION SNDRV_PROTOCOL_VERSION(0, 1, 1)
> > +#define SNDRV_COMPRESS_VERSION SNDRV_PROTOCOL_VERSION(0, 1, 2)
> > /**
> > * struct snd_compressed_buffer: compressed buffer
> > * @fragment_size: size of buffer fragment in bytes
> > @@ -67,8 +67,8 @@ struct snd_compr_params {
> > struct snd_compr_tstamp {
> > __u32 byte_offset;
> > __u32 copied_total;
> > - snd_pcm_uframes_t pcm_frames;
> > - snd_pcm_uframes_t pcm_io_frames;
> > + __u32 pcm_frames;
> > + __u32 pcm_io_frames;
> > __u32 sampling_rate;
> > };
> >
> > --
> > 1.8.5
> >
> > _______________________________________________
> > Alsa-devel mailing list
> > Alsa-devel@alsa-project.org
> > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>
> --
>
prev parent reply other threads:[~2013-12-16 8:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-10 14:33 [PATCH] ALSA: compress: Fix 64bit ABI incompatibility Takashi Iwai
2013-12-15 13:57 ` Vinod Koul
2013-12-16 8:43 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hk3f5uqwh.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).