From: Takashi Iwai <tiwai@suse.de>
To: "Lin, Mengdong" <mengdong.lin@intel.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Subject: Re: [PATCH 5/5] ALSA: hda - Make device D3 during runtime suspend
Date: Tue, 26 Nov 2013 14:53:46 +0100 [thread overview]
Message-ID: <s5hk3fv8e1h.wl%tiwai@suse.de> (raw)
In-Reply-To: <F46914AEC2663F4A9BB62374E5EEF8F80141B01B@SHSMSX101.ccr.corp.intel.com>
At Tue, 26 Nov 2013 13:32:11 +0000,
Lin, Mengdong wrote:
>
> > -----Original Message-----
> > From: alsa-devel-bounces@alsa-project.org
> > [mailto:alsa-devel-bounces@alsa-project.org] On Behalf Of Takashi Iwai
> > Sent: Tuesday, November 26, 2013 8:34 PM
> > To: alsa-devel@alsa-project.org
> > Subject: Re: [alsa-devel] [PATCH 5/5] ALSA: hda - Make device D3 during
> > runtime suspend
> >
> > At Tue, 26 Nov 2013 09:29:13 +0100,
> > Takashi Iwai wrote:
> > >
> > > We can make the device D3 for saving more power during the runtime
> > > suspend. Meanwhile, I observed that Haswell HDMI codecs gets
> > > corrupted ELD bytes when woken up from runtime suspend with D3.
> > > As a quick workaround, exclude these chips from D3.
> >
> > Scratch this. After reading the PCI core code, I found this patch is just a
> > nonsense.
>
> Could you share more info here?
>
> On Haswell, the HDMI audio controller (PCI device 3) and codec are in display power well, so the power saving is achieved by releasing and turning off the display power well.
>
> But at least for legacy audio, we need the controller (PCI device 1b) to enter D3 at runtime so PCI driver will call ACPI and BIOS can know the legacy audio controller is in D3 and power down the on-board codec.
The D3 state should be achieved by the runtime suspend code of PCI
driver itself, thus the driver doesn't have to do it. For details,
look at pci_pm_runtime_suspend() and pci_finish_runtime_suspend().
Takashi
prev parent reply other threads:[~2013-11-26 13:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-26 8:29 [PATCH 0/5] A few HD-audio things for 3.14 Takashi Iwai
2013-11-26 8:29 ` [PATCH 1/5] ALSA: hda - Split the generic parser as an individual module Takashi Iwai
2013-11-26 8:29 ` [PATCH 2/5] ALSA: hda - Bind with HDMI codec parser automatically Takashi Iwai
2013-11-26 8:29 ` [PATCH 3/5] ALSA: hda - Refactor pm notification in hda_codec.c Takashi Iwai
2013-11-26 8:29 ` [PATCH 4/5] ALSA: hda - Enable runtime PM on Panther Point Takashi Iwai
2013-11-26 8:29 ` [PATCH 5/5] ALSA: hda - Make device D3 during runtime suspend Takashi Iwai
2013-11-26 12:34 ` Takashi Iwai
2013-11-26 13:32 ` Lin, Mengdong
2013-11-26 13:53 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hk3fv8e1h.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=mengdong.lin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).