From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: usr/include/linux/soundcard.h warnings for 'make
	headers_check'
Date: Wed, 04 Feb 2009 12:43:03 +0100
Message-ID: <s5hk586a0mw.wl%tiwai@suse.de>
References: <1232465902.3088.31.camel@localhost.localdomain>
	<s5h7i4psepm.wl%tiwai@suse.de>
	<20090121054138.GA26551@uranus.ravnborg.org>
	<200902032127.24526.arnd@arndb.de>
	<1233720252.3595.5.camel@localhost.localdomain>
	<s5hhc3ak8ns.wl%tiwai@suse.de>
	<1233736494.3198.15.camel@localhost.localdomain>
	<s5h4ozak20l.wl%tiwai@suse.de>
	<1233743877.5563.7.camel@localhost.localdomain>
	<s5hy6wma2zw.wl%tiwai@suse.de>
	<1233747097.5563.29.camel@localhost.localdomain>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from mx2.suse.de (ns2.suse.de [195.135.220.15])
	by alsa0.perex.cz (Postfix) with ESMTP id C8EF42432C
	for <alsa-devel@alsa-project.org>; Wed,  4 Feb 2009 12:43:03 +0100 (CET)
In-Reply-To: <1233747097.5563.29.camel@localhost.localdomain>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Sender: alsa-devel-bounces@alsa-project.org
Errors-To: alsa-devel-bounces@alsa-project.org
To: Jaswinder Singh Rajput <jaswinder@kernel.org>
Cc: alsa-devel@alsa-project.org, Sam Ravnborg <sam@ravnborg.org>, Ingo Molnar <mingo@elte.hu>, Arnd Bergmann <arnd@arndb.de>, LKML <linux-kernel@vger.kernel.org>
List-Id: alsa-devel@alsa-project.org

At Wed, 04 Feb 2009 17:01:37 +0530,
Jaswinder Singh Rajput wrote:
> 
> On Wed, 2009-02-04 at 11:52 +0100, Takashi Iwai wrote:
> > At Wed, 04 Feb 2009 16:07:57 +0530,
> > Jaswinder Singh Rajput wrote:
> > > 
> > > In kernel space we use USE_SEQ_MACROS in:
> > > sound/oss/mpu401.c
> > > sound/oss/midi_synth.c
> > > 
> > > so we can replace
> > > #if (!defined(__KERNEL__) && !defined(KERNEL) && !defined(INKERNEL) && !defined(_KERNEL)) || defined(USE_SEQ_MACROS)
> > > with
> > > #ifdef USE_SEQ_MACROS
> > 
> > Then this will break user-space apps.  They don't define
> > USE_SEQ_MACROS always.
> > 
> 
> If userspace apps are coming through sys/soundcard.h

It's not always true -- that's the whole problem I'm concerned.
Apparently old apps do include linux/soundcard.h.

I agree to remove the stuff causing warnings, i.e. moving oss-lib part
to sys/soundcard.h.  In this case, the only possible regression is the
case where apps use OSS-lib and include linux/soundcard.h.  For other
cases (use sequencer stuff with linux/soundcard.h but without
oss-lib), it will still work.


Takashi