From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH 2/2] sis7019: add support for
	pre-2.6	kernels
Date: Thu, 13 Dec 2007 16:50:56 +0100
Message-ID: <s5hk5ni7fvj.wl%tiwai@suse.de>
References: <1197158043.3588.52.camel@obelisk.thedillows.org>
	<1197273182.31526.1225705529@webmail.messagingengine.com>
	<1197296683.3994.11.camel@obelisk.thedillows.org>
	<1197298124.31051.1225761969@webmail.messagingengine.com>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from mx2.suse.de (ns2.suse.de [195.135.220.15])
	by alsa0.perex.cz (Postfix) with ESMTP id 3100F103841
	for <alsa-devel@alsa-project.org>; Thu, 13 Dec 2007 18:01:18 +0100 (CET)
In-Reply-To: <1197298124.31051.1225761969@webmail.messagingengine.com>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Sender: alsa-devel-bounces@alsa-project.org
Errors-To: alsa-devel-bounces@alsa-project.org
To: Clemens Ladisch <cladisch@fastmail.net>
Cc: alsa-devel@alsa-project.org, Dave Dillow <dave@thedillows.org>
List-Id: alsa-devel@alsa-project.org

At Mon, 10 Dec 2007 15:48:44 +0100,
Clemens Ladisch wrote:
> 
> Dave Dillow wrote:
> > On Mon, 2007-12-10 at 08:53 +0100, Clemens Ladisch wrote:
> > > Dave Dillow wrote:
> > > > The sis7019 driver uses __ffs(), which is available in 2.6 kernels, but
> > > > not in most earlier ones. This patches the driver to use a local version
> > > > assembly version, as the hardware is SiS 55x only (i486/Pentium-ish).
> > > > 
> > > > ++#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,0)
> > > > ++static inline unsigned long sis_ffs(unsigned long word)
> > > > ++{
> > > > ++	__asm__("bsfl %1,%0"
> > > > ++		:"=r" (word)
> > > > ++		:"rm" (word));
> > > > ++	return word;
> > > > ++}
> > > > ++#endif
> > > 
> > > This should go into alsa-driver/include/adriver.h.
> > 
> > I'm not sure -- there's no other inline assembly there, and if I provide
> > an x86 _ffs() fallback, then it'll break on other architectures...
> 
> It won't break unless another driver actually uses __ffs(), and then we
> can still add a generic implementation.

Yep, it seems so.  The invalid asm codes becomes an error only at
assembler -> binary level, so it's harmless unless it's really used in
the driver code.

Anyway, uninitialized_var() should be ported to adriver.h as well.
Then we'll have a clean sis7019.c in alsa-driver tree, too.


Takashi