From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84CECC433E0 for ; Tue, 2 Mar 2021 09:25:07 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A516B64F0D for ; Tue, 2 Mar 2021 09:25:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A516B64F0D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 19A6A170A; Tue, 2 Mar 2021 10:24:15 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 19A6A170A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1614677105; bh=zAUFp61au4T3RBp+aioTt9LbbubGaPORCKaUpxY2TRc=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=ndYc3inDDl7qKvGOagfRlkwHxzyai/6Pmf/IHKJp3mU6qAbXtW5WLXHchyODRbGoQ 5sw9VU2Gg0gcQWvRtRhHsUG2Jinum1A6n0KnLstgXdfbIzSS7ttDnei4DLoCs4AEJ3 ZdCOrtku+z8z6nuLwfd2ftoCUcbP8Nzvlrwz5Y3U= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id AA7ABF80227; Tue, 2 Mar 2021 10:24:14 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 086F5F8025B; Tue, 2 Mar 2021 10:24:13 +0100 (CET) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id C5818F80088 for ; Tue, 2 Mar 2021 10:24:06 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz C5818F80088 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 3D833AAC5; Tue, 2 Mar 2021 09:24:06 +0000 (UTC) Date: Tue, 02 Mar 2021 10:24:06 +0100 Message-ID: From: Takashi Iwai To: Pierre-Louis Bossart Subject: Re: [PATCH] ALSA: hda: intel-nhlt: verify config type In-Reply-To: <20210302000146.1177770-1-pierre-louis.bossart@linux.intel.com> References: <20210302000146.1177770-1-pierre-louis.bossart@linux.intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org, Kai Vehmanen , Guennadi Liakhovetski , Cezary Rojewski , Rander Wang , broonie@kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, 02 Mar 2021 01:01:46 +0100, Pierre-Louis Bossart wrote: > > Multiple bug reports report issues with the SOF and SST drivers when > dealing with single microphone cases. > > We currently read the DMIC array information unconditionally but we > don't check that the configuration type is actually a mic array. > > When the DMIC link does not rely on a mic array configuration, the > recommendation is to check the format information to infer the maximum > number of channels, and map this to the number of microphones. > > This leaves a potential for a mismatch between actual microphones > available in hardware and what the ACPI table contains, but we have no > other source of information. > > Note that single microphone configurations can alternatively be > handled with a 'mic array' configuration along with a 'vendor-defined' > geometry. > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=201251 > BugLink: https://github.com/thesofproject/linux/issues/2725 > Fixes: 7a33ea70e1868 ('ALSA: hda: intel-nhlt: handle NHLT VENDOR_DEFINED DMIC geometry') > Signed-off-by: Pierre-Louis Bossart > Reviewed-by: Guennadi Liakhovetski > Reviewed-by: Rander Wang > Reviewed-by: Kai Vehmanen Thanks, applied. Takashi