From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2EAEC433E1 for ; Thu, 23 Jul 2020 13:19:22 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4EAB620737 for ; Thu, 23 Jul 2020 13:19:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="co6B1J3W" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4EAB620737 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id CA2821684; Thu, 23 Jul 2020 15:18:30 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz CA2821684 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1595510360; bh=EB2K7PyJ0cs7BsEVKT9EmnpbojNzrMksdoTUMLSxrCA=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=co6B1J3WkS5K6+JXzt3eYNxlCm2SUqYVC2Yzl5G3nBgT6Cc7IwNnyIKVdskmdbsOp WGM1kINgv6rJS9D3MIz3/qFrevx+Qjt4R8WUl1lsn5y2kDEDXi7wDEXcIuYVSXVXEt w0McUrzGPEZbf/OLeaWDUVQCK9GwLBdIVDM1G7/c= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 4E02BF8024A; Thu, 23 Jul 2020 15:17:44 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id EE429F800CE; Thu, 23 Jul 2020 15:17:39 +0200 (CEST) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 8AEE6F800CE for ; Thu, 23 Jul 2020 15:17:29 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 8AEE6F800CE X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 07FB5AB55; Thu, 23 Jul 2020 13:17:37 +0000 (UTC) Date: Thu, 23 Jul 2020 15:17:28 +0200 Message-ID: From: Takashi Iwai To: Vinod Koul Subject: Re: [RFC PATCH v2 0/6] ALSA: compress: add support to change codec profile in gapless playback In-Reply-To: <20200723130522.GB12965@vkoul-mobl> References: <20200721170007.4554-1-srinivas.kandagatla@linaro.org> <20200723130522.GB12965@vkoul-mobl> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org, ckeepax@opensource.cirrus.com, linux-kernel@vger.kernel.org, lgirdwood@gmail.com, tiwai@suse.com, broonie@kernel.org, Srinivas Kandagatla X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, 23 Jul 2020 15:05:22 +0200, Vinod Koul wrote: > > On 23-07-20, 14:38, Takashi Iwai wrote: > > On Tue, 21 Jul 2020 19:00:01 +0200, > > Srinivas Kandagatla wrote: > > > > > > For gapless playback it is possible that each track can have different > > > codec profile with same decoder, for example we have WMA album, > > > we may have different tracks as WMA v9, WMA v10 and so on > > > Or if DSP's like QDSP have abililty to switch decoders on single stream > > > for each track, then this call could be used to set new codec parameters. > > > > > > Existing code does not allow to change this profile while doing gapless > > > playback. > > > > > > This patchset adds new SNDRV_COMPRESS_SET_CODEC_PARAMS IOCTL along with > > > flags in capablity structure to allow userspace to set this new > > > parameters required which switching codec profile, either for gapless > > > or cross fade usecase. > > > > One idea that came up at the previous audio conference regarding this > > implementation was to just allow SET_PARAMS during the stream is > > running (only if the driver sets the capability) instead of > > introducing yet a new ioctl and an ops. > > Would it make sense? > > That does sound good but only issue would be that we need to somehow > mark/document that buffer info is useless and would be discarded, how do > we do that? Yes, the buffer and no_wake_mode can be ignored in the gapless re-setup. Is your concern only about the documentation? Or something else needs to be changed significantly? It's a new scheme in anyway, so the documentation update is required... thanks, Takashi > > > I have no big objection to add a new ioctl if other people agree, > > though. > > > > > > thanks, > > > > Takashi > > -- > ~Vinod >