From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH] ASoC: add config to enable/disable asoc compress Date: Tue, 02 Jun 2015 14:01:23 +0200 Message-ID: References: <1432992511-864-1-git-send-email-yang.jie@intel.com> <20150602105814.GM14071@sirena.org.uk> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 281AC264FF0 for ; Tue, 2 Jun 2015 14:01:24 +0200 (CEST) In-Reply-To: <20150602105814.GM14071@sirena.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: vivian.zhang@intel.com, alsa-devel@alsa-project.org, liam.r.girdwood@intel.com List-Id: alsa-devel@alsa-project.org At Tue, 2 Jun 2015 11:58:14 +0100, Mark Brown wrote: > > On Sat, May 30, 2015 at 09:28:31PM +0800, Jie Yang wrote: > > > +ifneq ($(CONFIG_SND_SOC_COMPRESS),) > > +snd-soc-core-objs += soc-compress.o > > +endif > > If you want to make this optional why not make it a module so that the > Makefile looks more idiomatic? Only about Makefile, it can be simplified like snd-soc-core-$(CONFIG_SND_SOC_COMPRESS) += soc-compress.o But I agree with Mark. It would make more sense to split a module, as soc-compress.c isn't so small. For a small object, it's often better to keep in, as a module consumes more memory (it needs a page size). For a large size object, it's worth to consider to split. Takashi