From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: [ALSA-UTILS][PATCH] Add support for cplay and
	crecord
Date: Wed, 04 Mar 2015 17:21:20 +0100
Message-ID: <s5hlhjc7myn.wl-tiwai@suse.de>
References: <1425483360-1806-1-git-send-email-qais.yousef@imgtec.com>
 <20150304161013.GU2613@intel.com>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15])
 by alsa0.perex.cz (Postfix) with ESMTP id 96EFE26510B
 for <alsa-devel@alsa-project.org>; Wed,  4 Mar 2015 17:21:21 +0100 (CET)
In-Reply-To: <20150304161013.GU2613@intel.com>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/options/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel/>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Errors-To: alsa-devel-bounces@alsa-project.org
Sender: alsa-devel-bounces@alsa-project.org
To: Vinod Koul <vinod.koul@intel.com>
Cc: alsa-devel@alsa-project.org, Qais Yousef <qais.yousef@imgtec.com>, Mark Brown <broonie@kernel.org>
List-Id: alsa-devel@alsa-project.org

At Wed, 4 Mar 2015 21:40:13 +0530,
Vinod Koul wrote:
> 
> On Wed, Mar 04, 2015 at 03:36:00PM +0000, Qais Yousef wrote:
> > cplay and crecord use compress offload API to play and record compressed audio.
> > 
> > They're based on cplay and crec from tinycompress library using LGPL license.
> > 
> > For now cplay only supports playing mp3 files.
> > 
> > Signed-off-by: Qais Yousef <qais.yousef@imgtec.com>
> > Cc: Takashi Iwai <tiwai@suse.de>
> > Cc: Vinod Koul <vinod.koul@intel.com>
> > Cc: Mark Brown <broonie@kernel.org>
> > ---
> > I renamed crec to crecord also to match aplay and arecord, hopefully
> > you don't mind Vinod.
> No thats fine..
> 
> > 
> > This patch is dependent on my other patch that adds support for compress offload
> > to alsa-lib.
> And where is that, should have preceded this
> > 
> > I needed to include <sound/compress_params.h> in cplay.c and crec.c
> > but I couldn't find an example of any C file which directly includes <sound/*.h>
> > The norm seems to be to just include <alsa/asoundlib.h>. Do I need to
> > redefine structs from <sound/compress_params.h> to newly added <alsa/compress.h>?
> > <alsa/pcm.h> seems to redefine structs from <sound/asound.h>.
> These are kernel headers and should be in your include path if you have
> those installed

This can't be guaranteed because each kernel may provide a different
set of include files.  Currently alsa-lib is packaged as
self-contained so that it can be built with less dependency and
provide user-space also build without kernel headers.  That said, 
user-space apps should read only alsa/*.h, not sound/*.h in general,
except for the very h/w-specific one.  It's an intended separation.
(But it's a waste of spaces, yes.)


Takashi