From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH 1/3] sound: Include appropriate header file in pcsp/pcsp_input.c Date: Fri, 07 Feb 2014 18:25:15 +0100 Message-ID: References: <512472c7d96cf1c239ba3d0bc517891a7c2f9da1.1391791103.git.rashika.kheria@gmail.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <512472c7d96cf1c239ba3d0bc517891a7c2f9da1.1391791103.git.rashika.kheria@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: Rashika Kheria Cc: linux-kernel@vger.kernel.org, Jaroslav Kysela , alsa-devel@alsa-project.org, josh@joshtriplett.org List-Id: alsa-devel@alsa-project.org At Fri, 7 Feb 2014 22:11:53 +0530, Rashika Kheria wrote: >=20 > Include appropriate header file in drivers/pcsp/pcsp_input.c because = it > defines function whose prototype definitions are present in > drivers/pcsp/pcsp_input.h. >=20 > This eliminates the following warning in drivers/pcsp/pcsp_input.c: > sound/drivers/pcsp/pcsp_input.c:42:6: warning: no previous prototype = for =E2=80=98pcspkr_stop_sound=E2=80=99 [-Wmissing-prototypes] > sound/drivers/pcsp/pcsp_input.c:80:5: warning: no previous prototype = for =E2=80=98pcspkr_input_init=E2=80=99 [-Wmissing-prototypes] > sound/drivers/pcsp/pcsp_input.c:110:5: warning: no previous prototype= for =E2=80=98pcspkr_input_remove=E2=80=99 [-Wmissing-prototypes] >=20 > Signed-off-by: Rashika Kheria Thanks, applied all three patches. Takashi > --- > sound/drivers/pcsp/pcsp_input.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/sound/drivers/pcsp/pcsp_input.c b/sound/drivers/pcsp/pcs= p_input.c > index b874b0a..0ecf8a4 100644 > --- a/sound/drivers/pcsp/pcsp_input.c > +++ b/sound/drivers/pcsp/pcsp_input.c > @@ -16,6 +16,7 @@ > #include > #include > #include "pcsp.h" > +#include "pcsp_input.h" > =20 > static void pcspkr_do_sound(unsigned int count) > { > --=20 > 1.7.9.5 >=20