Re: Oops in snd_emu10k1_efx_playback_prepare

[Takashi Iwai <tiwai@suse.de>]

At Thu, 10 Mar 2005 16:35:45 -0500,
Lee Revell wrote:
> 
> On Wed, 2005-03-09 at 18:21 +0100, Takashi Iwai wrote:
> > At Wed, 09 Mar 2005 11:54:30 +0100,
> > I wrote:
> > > 
> > > At Wed, 09 Mar 2005 10:57:54 +0100,
> > > I wrote:
> > > > 
> > > > At Wed, 09 Mar 2005 00:56:19 -0500,
> > > > Lee Revell wrote:
> > > > > 
> > > > > I got an Oops again that seems to be caused by something in mu
> > > > > multichannel patch.  But, I don't really know what to make of it.
> > > > > 
> > > > > ksymoops seems broken for 2.6 kernels, but it was able to disassemble
> > > > > the offending code.
> > > > > 
> > > > > Any ideas?
> > > > 
> > > > In snd_emu10k1_pcm_channel_alloc(), epcm->voices[2..NUM_EFX_PLAYBACK]
> > > > are not freed correctly.  Possibly did this hit?
> > > 
> > > Or maybe I misread the code.  Need more coffee now... :)
> > > 
> > > Anyway, snd_emu10k1_pcm_channel_alloc() should return immediately at
> > > the second or later call when all voices have been already allocated.
> > 
> > The quick fix patch is below.
> > But I'm not sure whether this is really related with the given bug.
> > 
> 
> Thanks, I'll try this.  Unfortunately the bug is very hard to hit (I
> have only triggered it twice) and I have no idea how to reproduce it.
> It's somwhow associated with restarting JACK.

I'll apply this fix to CVS anyway.
Please report if you hit the bug again.


thanks,

Takashi


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click