From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38FC4C433FE for ; Wed, 9 Dec 2020 16:10:22 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EBB0123B51 for ; Wed, 9 Dec 2020 16:10:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EBB0123B51 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 3D6A316B8; Wed, 9 Dec 2020 17:09:29 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 3D6A316B8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1607530219; bh=A9fSdemtapJdXZdu712/Y5S896PX0ghF2Ve1ktvpjKA=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=tY0ys8CWIVPM7RzLz1BXzosj/UoSNeALeQjVlbC9El52n09R/p+FIoq60wvUg1OWO WQb0Pak1dTuiQ7aUfFM5svzWVN7qLcMWTdzvTZDUm9lAauf/Kvab3Yk4SibM0mZca0 Dw6tDo/9VOOuyo0pmjGRcINRqo2nMT+LVdoys2zI= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 9DD1AF800EF; Wed, 9 Dec 2020 17:09:28 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 58148F8021D; Wed, 9 Dec 2020 17:09:27 +0100 (CET) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 16B01F801D8 for ; Wed, 9 Dec 2020 17:09:22 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 16B01F801D8 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 5A986AF98; Wed, 9 Dec 2020 16:09:22 +0000 (UTC) Date: Wed, 09 Dec 2020 17:09:22 +0100 Message-ID: From: Takashi Iwai To: Kilian Subject: Re: Steinberg UR22 Crackling and Clicks In-Reply-To: References: <61da73624ff3855867b8e65936fc2e1c@posteo.de> <987d1956f52ba49dc3b587c33e08bfb2@posteo.de> <4188489e2967b44e57653193cab9d1cb@posteo.de> <5811c5724e831c38395d3e5b57439b4d@posteo.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Wed, 09 Dec 2020 17:07:53 +0100, Kilian wrote: > > >> > Then try to pass implicit_fb=1 option to snd-usb-audio module. > >> > It's a new option that was added recently. > >> > > >> > > >> > Takashi > >> > >> Nice, that did the trick. there was a small glitch on first playback > >> but I can not reproduce it now. Playback seems glitch-free now. I will > >> test it with pulseaudio in the gui if I can. It's not quite easy to > >> test, because the system locks up after a while with the new kernel > >> and gnome 3. I will also test concurrent playback and recording, > >> too. Thank you very much, that was a huge help! > > > > Good to hear. If the implicit_fb option works, we can add a static > > quirk table entry easily. Just add IMPLICIT_FB_GENERIC_DEV() with the > > device ID to playback_implicit_fb_quirks[] table in > > sound/usb/implicit.c. > > > > > > Takashi > > Still having problems with the nouveau driver, so i couldn't thest > this with pulseaudio. Recording with arecord works parallel to playing > back with aplay. so here is my patch for implicit.c OK, I'll cook up the proper patch and submit for 5.11 merge. thanks, Takashi > diff --git a/sound/usb/implicit.c b/sound/usb/implicit.c > index 386198b36b87..c729ff634b9d 100644 > --- a/sound/usb/implicit.c > +++ b/sound/usb/implicit.c > @@ -46,6 +46,7 @@ static const struct snd_usb_implicit_fb_match > playback_implicit_fb_quirks[] = { > IMPLICIT_FB_GENERIC_DEV(0x0763, 0x2081), /* M-Audio FastTrack > Ultra */ > IMPLICIT_FB_GENERIC_DEV(0x0763, 0x2030), /* M-Audio Fast Track > C400 */ > IMPLICIT_FB_GENERIC_DEV(0x0763, 0x2031), /* M-Audio Fast Track > C600 */ > + IMPLICIT_FB_GENERIC_DEV(0x0499, 0x1509), /* Steinberg UR22 */ > > /* Fixed EP */ > /* FIXME: check the availability of generic matching */ >