From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72CC2C4363D for ; Tue, 6 Oct 2020 12:25:44 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5A5F720663 for ; Tue, 6 Oct 2020 12:25:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="MOJlUg5q" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5A5F720663 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id C232F1754; Tue, 6 Oct 2020 14:24:51 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz C232F1754 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1601987141; bh=4e+2j/NL5zBEF5jRbQPZHLvJrBwhGyVJCg40fbhy1Kw=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=MOJlUg5qQuPIuuPp1WLC6u4DF5yhO6IaXijYI1P5laH4aYN60k911YRKszuJ3s73R ZfwkOW0TeqH1bKptL1ZfxJaM5pZNbtTQ6NxTaiWd2if+Yiq2LaUh2o2tbjpQHqLOHn txiZBg4OhgW4qIQuRZAacn+ZbGIG1NdLu33qTiOw= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id D8EE6F80053; Tue, 6 Oct 2020 14:24:50 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 31939F8012C; Tue, 6 Oct 2020 14:24:49 +0200 (CEST) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id D7CBEF80053 for ; Tue, 6 Oct 2020 14:24:42 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz D7CBEF80053 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id DEB49B03B; Tue, 6 Oct 2020 12:24:41 +0000 (UTC) Date: Tue, 06 Oct 2020 14:24:41 +0200 Message-ID: From: Takashi Iwai To: Jian-Hong Pan Subject: Re: [PATCH] ALSA: hda/realtek: Enable audio jacks of ASUS D700SA with ALC887 In-Reply-To: <20201006075334.92933-1-jhp@endlessos.org> References: <20201006075334.92933-1-jhp@endlessos.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org, Kailang Yang , linux@endlessm.com, Takashi Iwai , linux-kernel@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, 06 Oct 2020 09:53:35 +0200, Jian-Hong Pan wrote: > > The ASUS D700SA desktop's audio (1043:2390) with ALC887 cannot detect > the headset microphone and another headphone jack until > ALC887_FIXUP_ASUS_HMIC and ALC887_FIXUP_ASUS_AUDIO quirks are applied. > The NID 0x15 maps as the headset microphone and NID 0x19 maps as another > headphone jack. Also need the function like alc887_fixup_asus_jack to > enable the audio jacks. > > Signed-off-by: Jian-Hong Pan > Signed-off-by: Kailang Yang > --- > sound/pci/hda/patch_realtek.c | 41 +++++++++++++++++++++++++++++++++++ > 1 file changed, 41 insertions(+) > > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c > index d4f17b465892..8d0928bdc9ff 100644 > --- a/sound/pci/hda/patch_realtek.c > +++ b/sound/pci/hda/patch_realtek.c > @@ -1929,6 +1929,8 @@ enum { > ALC1220_FIXUP_CLEVO_P950, > ALC1220_FIXUP_CLEVO_PB51ED, > ALC1220_FIXUP_CLEVO_PB51ED_PINS, > + ALC887_FIXUP_ASUS_AUDIO, > + ALC887_FIXUP_ASUS_HMIC, > }; > > static void alc889_fixup_coef(struct hda_codec *codec, > @@ -2141,6 +2143,30 @@ static void alc1220_fixup_clevo_pb51ed(struct hda_codec *codec, > alc_fixup_headset_mode_no_hp_mic(codec, fix, action); > } > > +static void alc887_asus_hp_automute_hook(struct hda_codec *codec, > + struct hda_jack_callback *jack) > +{ > + struct alc_spec *spec = codec->spec; > + int vref; > + > + snd_hda_gen_hp_automute(codec, jack); > + > + vref = spec->gen.hp_jack_present ? 0xc4 : 0xc0; Use the AC_PINCTL_* instead of the raw numbers. Some values are shortened form in hda_local.h, too (e.g. 0xc0 = PIN_HP). > + snd_hda_codec_write(codec, 0x19, 0, AC_VERB_SET_PIN_WIDGET_CONTROL, > + vref); Better to use snd_hda_set_pin_ctl(). > +} > + > +static void alc887_fixup_asus_jack(struct hda_codec *codec, > + const struct hda_fixup *fix, int action) > +{ > + struct alc_spec *spec = codec->spec; > + if (action != HDA_FIXUP_ACT_PROBE) > + return; > + snd_hda_codec_write(codec, 0x1b, 0, AC_VERB_SET_PIN_WIDGET_CONTROL, > + 0xc0); This one would be snd_hda_set_pin_ctl_cached(), so that it'll be restored at resume. thanks, Takashi