From: Takashi Iwai <tiwai@suse.de>
To: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Cc: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>,
alsa-devel@alsa-project.org,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
Rander Wang <rander.wang@intel.com>,
Bard Liao <yung-chuan.liao@linux.intel.com>
Subject: Re: [PATCH] ALSA: hda: fix a runtime pm issue in SOF when integrated GPU is disabled
Date: Wed, 02 Sep 2020 19:32:16 +0200 [thread overview]
Message-ID: <s5hmu2884pr.wl-tiwai@suse.de> (raw)
In-Reply-To: <20200902154218.1440441-1-kai.vehmanen@linux.intel.com>
On Wed, 02 Sep 2020 17:42:18 +0200,
Kai Vehmanen wrote:
>
> From: Rander Wang <rander.wang@intel.com>
>
> In snd_hdac_device_init pm_runtime_set_active is called to
> increase child_count in parent device. But when it is failed
> to build connection with GPU for one case that integrated
> graphic gpu is disabled, snd_hdac_ext_bus_device_exit will be
> invoked to clean up a HD-audio extended codec base device. At
> this time the child_count of parent is not decreased, which
> makes parent device can't get suspended.
>
> This patch calls pm_runtime_set_suspended to decrease child_count
> in parent device in snd_hdac_device_exit to match with
> snd_hdac_device_init. pm_runtime_set_suspended can make sure that
> it will not decrease child_count if the device is already suspended.
>
> Signed-off-by: Rander Wang <rander.wang@intel.com>
> Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
> Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
> Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
> Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Applied now. Thanks.
Takashi
prev parent reply other threads:[~2020-09-02 17:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-02 15:42 [PATCH] ALSA: hda: fix a runtime pm issue in SOF when integrated GPU is disabled Kai Vehmanen
2020-09-02 17:32 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hmu2884pr.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=guennadi.liakhovetski@linux.intel.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=rander.wang@intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox