From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44F2BC282DD for ; Wed, 8 Jan 2020 19:13:14 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5A7A420705 for ; Wed, 8 Jan 2020 19:13:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="Cv927W+q" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5A7A420705 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 339D8171D; Wed, 8 Jan 2020 20:12:21 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 339D8171D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1578510791; bh=PGU46E3Sx4XpQ0yDEink6K1/fAzr+nTT6jsYFErXXd4=; h=Date:From:To:In-Reply-To:References:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Cv927W+qdhisE8sOdwLwYM0B7MQTgkTUHJbebGeKyHU8aDvFhwDbS7dzrfxRF8IiL klLGmeM8gM8EckcIVNGDJGSLksRqWKsheCEJRE2TgB8KIl7W+vBBVo5AA7sFDuXkGr 2Tg5GYgY46tqQUsYHhhHriQuPTQ/QCNQ9Hd8D++k= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 8A499F8010B; Wed, 8 Jan 2020 20:12:20 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 483A7F80159; Wed, 8 Jan 2020 20:12:19 +0100 (CET) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 25156F80116 for ; Wed, 8 Jan 2020 20:12:14 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 25156F80116 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 1D8A0ABC7; Wed, 8 Jan 2020 19:12:14 +0000 (UTC) Date: Wed, 08 Jan 2020 20:12:13 +0100 Message-ID: From: Takashi Iwai To: Kai Vehmanen In-Reply-To: <20200108180856.5194-1-kai.vehmanen@linux.intel.com> References: <20200108180856.5194-1-kai.vehmanen@linux.intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Cc: alsa-devel@alsa-project.org Subject: Re: [alsa-devel] [PATCH] ALSA: hda: enable regmap internal locking X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Wed, 08 Jan 2020 19:08:56 +0100, Kai Vehmanen wrote: > > This reverts commit 42ec336f1f9d ("ALSA: hda: Disable regmap > internal locking"). > > Without regmap locking, there is a race between snd_hda_codec_amp_init() > and PM callbacks issuing regcache_sync(). This was caught by > following kernel warning trace: > > <4> [358.080081] WARNING: CPU: 2 PID: 4157 at drivers/base/regmap/regcache.c:498 regcache_cache_only+0xf5/0x130 > [...] > <4> [358.080148] Call Trace: > <4> [358.080158] snd_hda_codec_amp_init+0x4e/0x100 [snd_hda_codec] > <4> [358.080169] snd_hda_codec_amp_init_stereo+0x40/0x80 [snd_hda_codec] > > Suggested-by: Takashi Iwai > BugLink: https://gitlab.freedesktop.org/drm/intel/issues/592 > Signed-off-by: Kai Vehmanen Applied now. Thanks. Takashi _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel