Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Cc: libin.yang@intel.com, alsa-devel@alsa-project.org,
	broonie@kernel.org, pierre-louis.bossart@linux.intel.com
Subject: Re: [alsa-devel] [PATCH v7 6/9] ASoC: Intel: bxt-da7219-max98357a: common hdmi codec support
Date: Mon, 28 Oct 2019 19:04:34 +0100	[thread overview]
Message-ID: <s5hmudku4p9.wl-tiwai@suse.de> (raw)
In-Reply-To: <alpine.DEB.2.21.1910281931040.16459@zeliteleevi>

On Mon, 28 Oct 2019 18:33:44 +0100,
Kai Vehmanen wrote:
> 
> Hi,
> 
> thanks for the review!
> 
> On Mon, 28 Oct 2019, Takashi Iwai wrote:
> 
> > On Wed, 23 Oct 2019 11:03:28 +0200,
> > Kai Vehmanen wrote:
> > > -snd-soc-sst-bxt-da7219_max98357a-objs := bxt_da7219_max98357a.o
> > > +snd-soc-sst-bxt-da7219_max98357a-objs := bxt_da7219_max98357a.o hda_dsp_common.o
> > 
> > Hrm, this can be a problem.  I see there are multiple drivers that are
> > built with this object.  When they are built as modules and more than
> > one module get loaded on a system, it'll lead to a conflict because
> > both modules try to put the same stuff.
> [...]
> > But I'm not entirely sure whether this is true on the recent kernel
> > build.  At least it *was* a problem in the past.
> > 
> > In anyway, please try to load the two modules on your system and check
> > whether the module loading works.
> 
> hmm, did a quick test and no problems seen, all modules load fine.
> 
> Another option is to go back to solution in v6 of the series and
> have the helper functions inlines. But it seems v7 works as well, so maybe 
> we'll stick with this.

Hrm, then it might be built-in + module mixed case.  If that works, it
implies that my concern can be ignored.  Let's see.


thanks,

Takashi
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

  reply	other threads:[~2019-10-28 18:05 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-23  9:03 [alsa-devel] [PATCH v7 0/9] adapt SOF to use snd-hda-codec-hdmi Kai Vehmanen
2019-10-23  9:03 ` [alsa-devel] [PATCH v7 1/9] ALSA: hda/hdmi - implement mst_no_extra_pcms flag Kai Vehmanen
2019-10-23  9:03 ` [alsa-devel] [PATCH v7 2/9] ASoC: hdac_hda: add support for HDMI/DP as a HDA codec Kai Vehmanen
2019-10-23  9:03 ` [alsa-devel] [PATCH v7 3/9] ASoC: Intel: skl-hda-dsp-generic: use snd-hda-codec-hdmi Kai Vehmanen
2019-10-23  9:03 ` [alsa-devel] [PATCH v7 4/9] ASoC: Intel: skl-hda-dsp-generic: fix include guard name Kai Vehmanen
2019-10-23  9:03 ` [alsa-devel] [PATCH v7 5/9] ASoC: SOF: Intel: add support for snd-hda-codec-hdmi Kai Vehmanen
2019-10-28 16:54   ` Takashi Iwai
2019-10-23  9:03 ` [alsa-devel] [PATCH v7 6/9] ASoC: Intel: bxt-da7219-max98357a: common hdmi codec support Kai Vehmanen
2019-10-28 16:58   ` Takashi Iwai
2019-10-28 17:24     ` Pierre-Louis Bossart
2019-10-28 17:55       ` Kai Vehmanen
2019-10-28 17:33     ` Kai Vehmanen
2019-10-28 18:04       ` Takashi Iwai [this message]
2019-10-23  9:03 ` [alsa-devel] [PATCH v7 7/9] ASoC: Intel: glk_rt5682_max98357a: " Kai Vehmanen
2019-10-23  9:03 ` [alsa-devel] [PATCH v7 8/9] ASoC: intel: sof_rt5682: " Kai Vehmanen
2019-10-23  9:03 ` [alsa-devel] [PATCH v7 9/9] ASoC: Intel: bxt_rt298: " Kai Vehmanen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hmudku4p9.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=kai.vehmanen@linux.intel.com \
    --cc=libin.yang@intel.com \
    --cc=pierre-louis.bossart@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox