alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Lassi Ylikojola <lassi.ylikojola@gmail.com>
Cc: arvind.yadav.cs@gmail.com, alsa-devel@alsa-project.org,
	linux-kernel@vger.kernel.org, bhumirks@gmail.com
Subject: Re: [PATCH] ALSA: usb-audio: add implicit fb quirk for Behringer UFX1204
Date: Mon, 12 Feb 2018 08:24:30 +0100	[thread overview]
Message-ID: <s5hmv0eacwh.wl-tiwai@suse.de> (raw)
In-Reply-To: <95a0b1fe-24e3-e902-8452-0b28c2c95315@gmail.com>

On Fri, 09 Feb 2018 15:51:36 +0100,
Lassi Ylikojola wrote:
> 
> Add quirk to ensure a sync endpoint is properly configured.
> This patch is a fix for same symptoms on Behringer UFX1204 as patch
> from Albertto Aquirre on Dec 8 2016 for Axe-Fx II.
> Resending. Seems that there is a difference between git diff/commit versions 2.7.4 and 2.14.3.
> I had to insert a line break with 2.4.13 to align properly(hopefully). 

Hrm, still some mess with the embedded patch, but never mind, I fixed
manually and applied to my tree.

But at the next time if you resend a patch, please refresh completely,
not continuing a thread with "Re:" to the subject.  Maybe you can try
git-send-email at the next time.


thanks,

Takashi

> 
> Signed-off-by: Lassi Ylikojola <lassi.ylikojola@gmail.com>
> ---
>  sound/usb/pcm.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/sound/usb/pcm.c b/sound/usb/pcm.c
> index b9c9a19f9588..116a6ccc5b31 100644
> --- a/sound/usb/pcm.c
> +++ b/sound/usb/pcm.c
> @@ -357,6 +357,16 @@ static int set_sync_ep_implicit_fb_quirk(struct snd_usb_substream *subs,
>  
>                 alts = &iface->altsetting[1];
>                 goto add_sync_ep;
> +       case USB_ID(0x1397, 0x0002):
> +               ep = 0x81;
> +               iface = usb_ifnum_to_if(dev, 1);
> +
> +               if (!iface || iface->num_altsetting == 0)
> +                       return -EINVAL;
> +
> +               alts = &iface->altsetting[1];
> +               goto add_sync_ep;
> +
>  
>         }
>         if (attr == USB_ENDPOINT_SYNC_ASYNC &&
> -- 
> 2.14.3
> 

      reply	other threads:[~2018-02-12  7:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-03 14:42 [PATCH] ALSA: usb-audio: add implicit fb quirk for Behringer UFX1204 Lassi Ylikojola
2018-02-07  5:47 ` Takashi Iwai
2018-02-09 14:51   ` Lassi Ylikojola
2018-02-12  7:24     ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hmv0eacwh.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=arvind.yadav.cs@gmail.com \
    --cc=bhumirks@gmail.com \
    --cc=lassi.ylikojola@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).