From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH] ASoC: intel: Fix PM and non-atomic crash
	in bytcr drivers
Date: Mon, 24 Apr 2017 23:45:45 +0200
Message-ID: <s5hmvb5iinq.wl-tiwai@suse.de>
References: <20170424120955.15519-1-tiwai@suse.de>
 <14ce353a-5dd5-76bc-d98b-d0d3e8b4e757@linux.intel.com>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from mx1.suse.de (mx2.suse.de [195.135.220.15])
 by alsa0.perex.cz (Postfix) with ESMTP id 30BBA266AF7
 for <alsa-devel@alsa-project.org>; Mon, 24 Apr 2017 23:45:45 +0200 (CEST)
In-Reply-To: <14ce353a-5dd5-76bc-d98b-d0d3e8b4e757@linux.intel.com>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/options/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel/>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Errors-To: alsa-devel-bounces@alsa-project.org
Sender: alsa-devel-bounces@alsa-project.org
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: Vinod Koul <vinod.koul@intel.com>, Liam Girdwood <liam.r.girdwood@linux.intel.com>, alsa-devel@alsa-project.org, Mark Brown <broonie@kernel.org>
List-Id: alsa-devel@alsa-project.org

On Mon, 24 Apr 2017 23:39:47 +0200,
Pierre-Louis Bossart wrote:
> 
> 
> 
> On 04/24/2017 07:09 AM, Takashi Iwai wrote:
> > The FE setups of Intel SST bytcr_rt5640 and bytcr_rt5651 drivers carry
> > the ignore_suspend flag, and this prevents the suspend/resume working
> > properly while the stream is running, since SST core code has the
> > check of the running streams and returns -EBUSY.  Drop these
> > superfluous flags for fixing the behavior.
> >
> > Also, the bytcr_rt5640 driver lacks of nonatomic flag in some FE
> > definitions, which leads to the kernel Oops at suspend/resume like:
> This patch also fixes the known bug that reboot had to be forced on
> some BYT platforms with a manual restart when the audio driver was
> enabled.
> Thanks Takashi!

While we're at it: could you submit the UCM profiles as alsa-lib
upstream?  At least the ones for the drivers that are in the current
kernel should be merged.

If there are multiple board-specific UCMs for the same driver, we can
use now card's longname (generated from DMI string) as the primary
source, while keeping the $DRIVER/$DRIVER.conf as the fallback.


thanks,

Takashi