From: Takashi Iwai <tiwai@suse.de>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH 1/2] ALSA: usb: fix corrupted pointers due to interface setting change
Date: Fri, 14 Aug 2015 17:54:07 +0200 [thread overview]
Message-ID: <s5hmvxtsw68.wl-tiwai@suse.de> (raw)
In-Reply-To: <s5hpp2pswgg.wl-tiwai@suse.de>
On Fri, 14 Aug 2015 17:47:59 +0200,
Takashi Iwai wrote:
>
> On Fri, 14 Aug 2015 17:39:32 +0200,
> Pierre-Louis Bossart wrote:
> >
> > On 8/14/15 10:28 AM, Takashi Iwai wrote:
> > > On Fri, 14 Aug 2015 17:03:10 +0200,
> > > Takashi Iwai wrote:
> > >>
> > >> On Fri, 14 Aug 2015 00:42:32 +0200,
> > >> Pierre-Louis Bossart wrote:
> > >>>
> > >>> When a transition occurs between alternate settings that do not use the
> > >>> same synchronization method, the substream pointers were not reset.
> > >>> This prevents audio from being played during the second transition.
> > >>>
> > >>> Identified and tested with M-Audio Transit device
> > >>> (0763:2006 Midiman M-Audio Transit)
> > >>
> > >> Hmm, I have this old device, too, but couldn't reproduce the problem.
> > >> Is there any special setup with it?
> > >
> > > OK, I could see it after switching a few times. But, also your patch
> > > didn't cure, either...
> >
> > I tested this with Ubuntu 14.04 and the default madfuload package that
> > comes with it for the firmware.
> >
> > I think you need both patches to get the device to work. I split the
> > patches in two since I think the second problem is device specific while
> > the first one is a generic one that can happen on other devices.
>
> I tested both at once, of course :)
> With my device, 24/96 -> 16/48 works, then again switching to 24/96
> stalls. After that, it doesn't work no matter which mode is until I
> replug the device.
Hmm, now after a few retrials, it starts working.
Will review both patches now.
Takashi
next prev parent reply other threads:[~2015-08-14 15:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-13 22:42 [PATCH 0/2] USB audio fixes Pierre-Louis Bossart
2015-08-13 22:42 ` [PATCH 1/2] ALSA: usb: fix corrupted pointers due to interface setting change Pierre-Louis Bossart
2015-08-14 15:03 ` Takashi Iwai
2015-08-14 15:28 ` Takashi Iwai
2015-08-14 15:39 ` Pierre-Louis Bossart
2015-08-14 15:47 ` Takashi Iwai
2015-08-14 15:54 ` Takashi Iwai [this message]
2015-08-14 15:57 ` Takashi Iwai
2015-08-14 16:05 ` Pierre-Louis Bossart
2015-08-13 22:42 ` [PATCH 2/2] ALSA: usb: handle descriptor with SYNC_NONE illegal value Pierre-Louis Bossart
2015-08-14 16:03 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hmvxtsw68.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=pierre-louis.bossart@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox