From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: ASoC updates for v4.2
Date: Mon, 22 Jun 2015 11:58:24 +0200
Message-ID: <s5hmvzs6p4v.wl-tiwai@suse.de>
References: <20150622092616.GN14071@sirena.org.uk>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15])
 by alsa0.perex.cz (Postfix) with ESMTP id C974B2617A5
 for <alsa-devel@alsa-project.org>; Mon, 22 Jun 2015 11:58:25 +0200 (CEST)
In-Reply-To: <20150622092616.GN14071@sirena.org.uk>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/options/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel/>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Errors-To: alsa-devel-bounces@alsa-project.org
Sender: alsa-devel-bounces@alsa-project.org
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, Koro Chen <koro.chen@mediatek.com>, Liam Girdwood <lgirdwood@gmail.com>
List-Id: alsa-devel@alsa-project.org

At Mon, 22 Jun 2015 10:26:16 +0100,
Mark Brown wrote:
> 
> The following changes since commit 0f57d86787d8b1076ea8f9cbdddda2a46d534a27:
> 
>   Linux 4.1-rc8 (2015-06-14 15:51:10 -1000)
> 
> are available in the git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git tags/asoc-v4.2-2
> 
> for you to fetch changes up to c99d49a8f81fb35e67b0ffa45f320a75e0b5639d:
> 
>   Merge remote-tracking branch 'asoc/topic/wm8995' into asoc-next (2015-06-22 10:24:37 +0100)
> 
> ----------------------------------------------------------------
> ASoC: Further updates for v4.2
> 
> There's a bunch of additional updates and fixes that came in since my
> orignal pull request here, including DT support for rt5645 and fairly
> large serieses of cleanups and improvements to tas2552 and rcar.

In addition to rsnd-card.c, I get a compile warning as below:

sound/soc/mediatek/mtk-afe-pcm.c:1035:12: warning: 'mtk_afe_runtime_suspend' defined but not used [-Wunused-function]

And, looking at the code, it seems calling runtime suspend in the
following way at probe:

        pm_runtime_enable(&pdev->dev);
        if (!pm_runtime_enabled(&pdev->dev)) {
                ret = mtk_afe_runtime_resume(&pdev->dev);
                if (ret)
                        goto err_pm_disable;
        }

I'm not sure whether this really behaves correctly, especially when a
kernel is built without CONFIG_PM.


Takashi