From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH v5 3/4] ASoC: Intel - add makefile support
	for SKL driver
Date: Mon, 15 Jun 2015 18:42:39 +0200
Message-ID: <s5hmw00gby8.wl-tiwai@suse.de>
References: <1434040438-14535-1-git-send-email-vinod.koul@intel.com>
 <1434040438-14535-4-git-send-email-vinod.koul@intel.com>
 <20150615155752.GV18309@sirena.org.uk>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15])
 by alsa0.perex.cz (Postfix) with ESMTP id 24E8C2652F1
 for <alsa-devel@alsa-project.org>; Mon, 15 Jun 2015 18:42:40 +0200 (CEST)
In-Reply-To: <20150615155752.GV18309@sirena.org.uk>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/options/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel/>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Errors-To: alsa-devel-bounces@alsa-project.org
Sender: alsa-devel-bounces@alsa-project.org
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, Vinod Koul <vinod.koul@intel.com>, liam.r.girdwood@linux.intel.com, patches.audio@intel.com, Jeeja KP <jeeja.kp@intel.com>, "Subhransu S. Prusty" <subhransu.s.prusty@intel.com>
List-Id: alsa-devel@alsa-project.org

At Mon, 15 Jun 2015 16:57:52 +0100,
Mark Brown wrote:
> 
> On Thu, Jun 11, 2015 at 10:03:57PM +0530, Vinod Koul wrote:
> 
> > +config SND_SKL_PREALLOC_SIZE
> > +	int "Pre-allocated buffer size for skylake HD-audio driver"
> > +	range 0 32768
> > +	default 64
> 
> Size in units of...?
> 
> > +	help
> > +	  Specifies the default pre-allocated buffer-size in kB for the
> > +	  HD-audio driver.  A larger buffer (e.g. 2048) is preferred
> > +	  for systems using PulseAudio.  The default 64 is chosen just
> > +	  for compatibility reasons.
> 
> What are those compatibility reasons - why should users have to worry
> about this?

... if a user wants to reduce the memory foot print.
2MB buffers for each stream are significant size, supposing that it
can have 16 streams.

> Should this be a module parameter or something?

The buffers can be reallocated dynamically via procfs in general, but
it's not practical and intuitive.  That's why the similar option was
provided for HDA legacy driver.  It was the time when PA started
accepted slowly.  I don't know whether it makes sense for SKL ASoC
driver, though -- it's up to you guys.


Takashi